[INS-70] Unify JDBC URL Parsing Across Detector and Analyzer (Continued) #4606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanfcp
approved these changes
Dec 17, 2025
Contributor
amanfcp
left a comment
amanfcp
left a comment
There was a problem hiding this comment.
This is cool! Thanks Mustansir
Now you've encapsulated all the methods and export only NewJDBC which is leaner approach.
I can't think of any reason for JDBC analyzer to use individual methods so we're good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR serves as an extension of #4574 by further refactoring the detector to unify code across JDBC's detector and analyzer.
Changes here will make better sense when viewed in conjunction with the corresponding analyzer PR.
Instead of publicizing seperate methods like
parseMySQLandbuildMySQLConnectionString, I've now added methods likeGetConnectionInfo,GetDBTypeandBuildConnectionStringto the existingJDBCinterface, so that both the detector and analyzer can directly use theNewJDBCmethod and then call the methods they need.Tests for parsing and building connection strings have been moved from the analyzer to the detector as well.
Checklist:
make test-community)?make lintthis requires golangci-lint)?