feat(ui): Implement scrollable skill version menu - #717
Merged
Conversation
vinit-truefoundry
requested review from
govindavashishtha,
kumarsks619,
qaifi-tf,
sajal-truefoundry and
sayan-truefoundry
as code owners
September 11, 2026 14:50
🦋 Changeset detectedLatest commit: dbea92e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
govindavashishtha
approved these changes
Sep 11, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 494d1ff. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Localized UI interaction changes in dropdown/bottom-sheet primitives with no auth, data, or API impact.
Overview
Makes long skill version lists usable by capping the version DropdownMenu at
max-h-64with vertical scrolling and enablinglockScroll, which blocks page wheel/touch scrolling outside the menu while it is open.Fixes a shared dropdown/bottom-sheet bug where close-on-click treated clicks on the menu’s own scrollbar as a dismiss: adds
isSurfaceClickso only clicks on menu items (not the empty surface/scrollbar) close the menu, and applies the same logic in ResponsiveDropdownMenu’s compact bottom sheet. The menu panel also getsoverscroll-containto reduce scroll chaining.Reviewed by Cursor Bugbot for commit dbea92e. Bugbot is set up for automated code reviews on this repo. Configure here.