Skip to content

feat(ui): Implement scrollable skill version menu - #717

Merged
vinit-truefoundry merged 5 commits into
mainfrom
bugfix/skills-dropdwon-scroll
Sep 13, 2026
Merged

feat(ui): Implement scrollable skill version menu#717
vinit-truefoundry merged 5 commits into
mainfrom
bugfix/skills-dropdwon-scroll

Conversation

@vinit-truefoundry

@vinit-truefoundry vinit-truefoundry commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Localized UI interaction changes in dropdown/bottom-sheet primitives with no auth, data, or API impact.

Overview
Makes long skill version lists usable by capping the version DropdownMenu at max-h-64 with vertical scrolling and enabling lockScroll, which blocks page wheel/touch scrolling outside the menu while it is open.

Fixes a shared dropdown/bottom-sheet bug where close-on-click treated clicks on the menu’s own scrollbar as a dismiss: adds isSurfaceClick so only clicks on menu items (not the empty surface/scrollbar) close the menu, and applies the same logic in ResponsiveDropdownMenu’s compact bottom sheet. The menu panel also gets overscroll-contain to reduce scroll chaining.

Reviewed by Cursor Bugbot for commit dbea92e. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: dbea92e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@truefoundry/trueforge-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 494d1ff. Configure here.

Comment thread packages/trueforge-ui/src/atoms/draft/SkillVersionSelector.tsx
@vinit-truefoundry
vinit-truefoundry enabled auto-merge (squash) September 13, 2026 07:36
@vinit-truefoundry
vinit-truefoundry merged commit 531f0ce into main Sep 13, 2026
10 checks passed
@vinit-truefoundry
vinit-truefoundry deleted the bugfix/skills-dropdwon-scroll branch September 13, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants