Skip to content

Release/v2.5.0#75

Merged
troberts-28 merged 8 commits intomainfrom
release/v2.5.0
Feb 8, 2026
Merged

Release/v2.5.0#75
troberts-28 merged 8 commits intomainfrom
release/v2.5.0

Conversation

@troberts-28
Copy link
Owner

@troberts-28 troberts-28 commented Feb 8, 2026

Note

Low Risk
Small, localized UI/imperative API changes; primary risk is minor visual regressions or altered behavior when setting values to 0.

Overview
Adds support for styling the currently selected picker value by threading a selectedValue through TimerPickerDurationScrollPickerItem, and introducing a new styles.selectedPickerItem override.

Fixes an imperative API edge case where TimerPickerRef.setValue would ignore 0 for days/hours/minutes/seconds by switching the checks to !== undefined.

Updates docs to mention selectedPickerItem, refreshes the Expo example dependencies (and yarn.lock), and trims/cleans up a few modal-related tests and formatting.

Written by Cursor Bugbot for commit 26aa036. This will update automatically on new commits. Configure here.

@troberts-28 troberts-28 merged commit ba5ff33 into main Feb 8, 2026
2 checks passed
@troberts-28 troberts-28 deleted the release/v2.5.0 branch February 8, 2026 20:07
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

intItem = parseInt(stringItem);
}

const isSelected = intItem === selectedValue;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12-hour picker selected item comparison uses mismatched formats

High Severity

In 12-hour picker mode, isSelected compares intItem (the displayed 12-hour value, range 1–12) with selectedValue (the internal 24-hour duration, range 0–23). These never correctly align: selecting "1 PM" sets selectedValue to 13 but intItem is 1, so the item isn't highlighted. Selecting "1 AM" (selectedValue = 1) incorrectly highlights both "1 AM" and "1 PM". Selecting "12 AM" (selectedValue = 0) highlights nothing since no intItem equals 0.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants