Conversation
#73 - TimerPicker.setValue() fails to handle zero values correctly
Add capability to style the currently selected time unit
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| intItem = parseInt(stringItem); | ||
| } | ||
|
|
||
| const isSelected = intItem === selectedValue; |
There was a problem hiding this comment.
12-hour picker selected item comparison uses mismatched formats
High Severity
In 12-hour picker mode, isSelected compares intItem (the displayed 12-hour value, range 1–12) with selectedValue (the internal 24-hour duration, range 0–23). These never correctly align: selecting "1 PM" sets selectedValue to 13 but intItem is 1, so the item isn't highlighted. Selecting "1 AM" (selectedValue = 1) incorrectly highlights both "1 AM" and "1 PM". Selecting "12 AM" (selectedValue = 0) highlights nothing since no intItem equals 0.


Note
Low Risk
Small, localized UI/imperative API changes; primary risk is minor visual regressions or altered behavior when setting values to
0.Overview
Adds support for styling the currently selected picker value by threading a
selectedValuethroughTimerPicker�DurationScroll�PickerItem, and introducing a newstyles.selectedPickerItemoverride.Fixes an imperative API edge case where
TimerPickerRef.setValuewould ignore0for days/hours/minutes/seconds by switching the checks to!== undefined.Updates docs to mention
selectedPickerItem, refreshes the Expo example dependencies (andyarn.lock), and trims/cleans up a few modal-related tests and formatting.Written by Cursor Bugbot for commit 26aa036. This will update automatically on new commits. Configure here.