Add macOS support#298
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 25 25
Lines 1260 1260
Branches 74 74
=======================================
Hits 1211 1211
Misses 45 45
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Nice to see you here @tristanmontoya ! Thanks for trying and sharing you recipe. In fact, running t8code on macOS is of great interest as well. So, did it everything work for you so far. I think it would be nice to integrate macos support! |
| next to the t8code library. (default: '\$(dirname \$T8CODE_LIBRARY)/ | ||
| libp4est.so') | ||
| 'path/to/libp4est.so' or 'path/to/libp4est.dylib'. If omitted, it | ||
| will be assumed to be located next to the t8code library. |
There was a problem hiding this comment.
The default wasn't actually changed for Linux, just wasn't mentioned specifically here. Added back the note saying what the default is, using the generic to denote either .so or .dylib.
So far all is working. I'll let you know if I'm running into any issues. The goal is to try to wrap Trixi.jl in the Basic Model Interface, which will allow it to interface with some of the land models we've been working with at the University of Saskatchewan. |
5c17144 to
2e32c93
Compare
Wanted to use libtrixi on my Mac, so with the help of Codex, I got it to work cross-platform and added a small macOS test workflow.