Open
Conversation
miyatakazuya
requested changes
Apr 4, 2026
Contributor
miyatakazuya
left a comment
miyatakazuya
left a comment
There was a problem hiding this comment.
The CI doesn't pass because of a mission semicolon in udp_client.hpp. Also the lint does not pass as well.
Also is there an associated PR in camera-things? I'm a bit confused on the structure of the PR
AskewParity
reviewed
Apr 4, 2026
include/network/udp_client.hpp
Outdated
| Header recvHeader(); | ||
|
|
||
| std::vector<std::uint8_t> recvBody(const int mem_size, const int total_chunks); | ||
| char recvPing() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #354.