Add allow_insecure_auth to opt out of the HTTP+auth guard - #633
Open
hashhar wants to merge 1 commit into
Open
Conversation
The client rejects credentials over plain http://, with no opt-out. This breaks topologies where the transport is encrypted below the application layer, e.g. an mTLS-terminating service mesh sidecar: the connection looks like plain HTTP but isn't insecure end-to-end. Add allow_insecure_auth (default False) to suppress the guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #494.
The client rejects credentials over plain
http://, with no opt-out. This breaks topologies where the transport is encrypted below the application layer, e.g. an mTLS-terminating service mesh sidecar: the connection looks like plain HTTP but isn't insecure end-to-end.Add
allow_insecure_auth(defaultFalse) to suppress the guard. If the coordinator has HTTPS enabled, Trino's ownhttp-server.authentication.allow-insecure-over-httpmust also be set server-side.Release notes
(x) Release notes are required, with the following suggested text: