fix(webapp): pin fast-xml-parser past the broken 5.7 window - #4959
ArjunCodess wants to merge 1 commit into
Conversation
|
|
Hi @ArjunCodess, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
addEntity("#xD"), and fast-xml-parser 5.7.0–5.7.1 rejects that name, so IRSA credential resolution never gets as far as parsing STS>=5 <5.7.0override stopped at 5.7.x, which is the broken window; this moves it to>=5 <5.8.0→^5.8.0and keeps the 4.x line as-isFixes #4951
Test plan
pnpm why fast-xml-parserno longer lists 5.7.0 or 5.7.1addEntity("#xD")thenparse("<a>1</a>", true)should not throw