fix #10909 unnecessary ssh password/passphrase prompts #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this PR addresses this issue in the main
dvcrepository treeverse/dvc#10909The main issue was, that no matter what ssh configuration you set, the passphrase for the key is always prompted, even if you use
ask_passwordand password based auth.This is due to the
InteractiveSSHClientstill trying to use thepublickeyauth if we don't set thepreferred_auth, i.e. we will always callpublic_key_auth_requested.I've tried to replicate this behavior by expanding the docker based ssh tests, please let me know if you need some additional details/tests/etc