Conversation
Member
Author
|
Superseded by #500, which now carries the whole change against main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Direct images have required source dimensions but used to reserve no space while request-time signing suspended. The responsive examples also supplied sizes without the corresponding CSS, and did not demonstrate an appropriately small avatar candidate set.
Changes
Verification
yarn workspace @transloadit/img check: 75 tests plus type fixtures.yarn test:img:fixture: packed production Next build, shell geometry attributes/CSS, avatar candidates, signing, authorization, tampering and secret exclusion.yarn checkand all GitHub checks.This is PR B, stacked on #497. No merge/publication. The geometry probe is not the later real-CDN/browser authorization suite; the orchestrator owns council review after the round.