feat: Add plan features and gating middleware - #12
Open
kofimokome wants to merge 3 commits into
Open
Conversation
kofimokome
marked this pull request as ready for review
July 6, 2026 20:27
Code Review SummaryThis PR introduces a feature gating mechanism including a dedicated middleware 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
Collaborator
Author
Collaborator
Author
kofimokome
marked this pull request as draft
August 3, 2026 19:07
# Conflicts: # src/CloudServiceProvider.php # Conflicts: # src/CloudServiceProvider.php
kofimokome
force-pushed
the
feat/entitlement
branch
from
August 24, 2026 17:36
97ad416 to
823b085
Compare
kofimokome
marked this pull request as ready for review
August 24, 2026 17:37
kofimokome
force-pushed
the
feat/entitlement
branch
from
August 24, 2026 17:42
823b085 to
9489b6e
Compare
| use Symfony\Component\HttpFoundation\Response; | ||
| use Whilesmart\Entitlements\Contracts\Entitlements; | ||
|
|
||
| class GateFeature |
There was a problem hiding this comment.
Use constructor injection for the Entitlements service instead of resolving it via the app() helper inside the handle method. This promotes better testability by allowing dependencies to be mocked easily and follows standard Laravel middleware patterns.
Suggested change
| class GateFeature | |
| class GateFeature | |
| { | |
| public function __construct( | |
| protected Entitlements $entitlements | |
| ) {} | |
| /** | |
| * Handle an incoming request. | |
| * | |
| * @param Request $request | |
| * @param Closure $next | |
| * @param string $feature | |
| * @return Response | |
| */ | |
| public function handle(Request $request, Closure $next, string $feature): Response | |
| { | |
| if (!$this->entitlements->allows($request->user(), $feature)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
Depends on #11