Conversation
traceloop.sdk imports both at import time, but neither was declared, so a clean install failed with ModuleNotFoundError: on requests with OpenTelemetry 1.45, whose HTTP exporter no longer depends on it, and on httpx with 1.44. uv lock also refreshes the local path packages to 0.62.3. Fixes traceloop#4526
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⛔ Files ignored due to path filters (1)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe ChangesSDK runtime dependencies
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The SDK’s HTTP dependencies are declared and reflected in its lockfile. No merge-blocking risk is evident; it is ready for normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Fixes #4526
traceloop-sdkimportsrequestsandhttpxwhentraceloop.sdkis imported, but neither was declared, sofrom traceloop.sdk import Traceloopfailed in a clean environment: onrequestswith OpenTelemetry 1.45, whose HTTP exporter no longer depends on it, and onhttpxwith OpenTelemetry 1.44.This adds both to the dependencies:
httpx>=0.23.0,<1: the SDK only usesAsyncClient,Timeout,Response,TimeoutExceptionandConnectError, which are stable across that range. It's also the range the OpenAI SDK allows, so the two install together.requests>=2.31.0,<3: matches the existingtypes-requestspin.Running
uv lock(the package'slocktarget) also refreshed the local path packages from 0.62.1 to 0.62.3 and one of their dependency markers, which the lock hadn't picked up since the last release.Verified by building the wheel and installing it in fresh virtualenvs:
from traceloop.sdk import Traceloopnow works with OpenTelemetry 1.45.0 and 1.44.0, andTraceloop.init()plus a@workflowspan export to a local OTLP receiver over both HTTP and gRPC.Summary by CodeRabbit