Skip to content

Remove deprecated upload_records method from qdrant instrumentor#4357

Open
DresdenGman wants to merge 2 commits into
traceloop:mainfrom
DresdenGman:fix/remove-upload-records
Open

Remove deprecated upload_records method from qdrant instrumentor#4357
DresdenGman wants to merge 2 commits into
traceloop:mainfrom
DresdenGman:fix/remove-upload-records

Conversation

@DresdenGman

@DresdenGman DresdenGman commented Jul 10, 2026

Copy link
Copy Markdown

The upload_records method was removed from qdrant-client 1.16.0, causing AttributeError during instrumentation. This PR removes it from both sync and async qdrant_client_methods.json files and cleans up the corresponding dead branch in wrapper.py.

Fixes #3492

Summary by CodeRabbit

  • Bug Fixes
    • Removed OpenTelemetry tracing for Qdrant upload_records operations.
    • Stopped recording upload-point count attributes for these operations.
    • Existing tracing for collection uploads, searches, and batch searches remains unchanged.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d33e6e19-84f2-44e9-98b4-d6e589cd2e20

📥 Commits

Reviewing files that changed from the base of the PR and between 93429cf and a50d3a3.

📒 Files selected for processing (3)
  • packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/async_qdrant_client_methods.json
  • packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/qdrant_client_methods.json
  • packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/wrapper.py
💤 Files with no reviewable changes (1)
  • packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/wrapper.py

📝 Walkthrough

Walkthrough

The Qdrant instrumentation removes upload_records from synchronous and asynchronous method mappings and deletes its method-specific wrapper branch.

Changes

Qdrant instrumentation updates

Layer / File(s) Summary
Remove upload_records instrumentation
packages/opentelemetry-instrumentation-qdrant/opentelemetry/instrumentation/qdrant/*
Synchronous and asynchronous mappings no longer configure qdrant.upload_records, and _wrap no longer handles upload_records attributes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing deprecated upload_records support from the Qdrant instrumentor.
Linked Issues check ✅ Passed The PR removes upload_records from sync and async instrumentation and the related wrapper branch, which addresses the reported QdrantClient 1.16.1 incompatibility.
Out of Scope Changes check ✅ Passed The changes are limited to removing the deprecated upload_records instrumentation and related cleanup, with no clear unrelated additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: opentelemetry-instrumentation-qdrant is incompatible with qdrant-client version 1.16.1

1 participant