-
Notifications
You must be signed in to change notification settings - Fork 470
Implement json_contains filter for SQLite backend #2121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Br1an67
wants to merge
2
commits into
tortoise:develop
Choose a base branch
from
Br1an67:fix/json-contains-sqlite
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import json | ||
|
|
||
| import aiosqlite | ||
| from pypika_tortoise.terms import Criterion, Term, ValueWrapper | ||
| from pypika_tortoise.terms import Function as PypikaFunction | ||
|
|
||
|
|
||
| class SQLiteJSONContains(PypikaFunction): | ||
| def __init__(self, column_name: Term, target: Term) -> None: | ||
| super().__init__("json_contains", column_name, target) | ||
|
|
||
|
|
||
| def sqlite_json_contains(field: Term, value: str) -> Criterion: | ||
| return SQLiteJSONContains(field, ValueWrapper(value)) | ||
|
|
||
|
|
||
| def _json_contains_impl(target_str: str | None, candidate_str: str | None) -> bool: | ||
| """Check if target JSON value contains the candidate JSON value. | ||
|
|
||
| Semantics match PostgreSQL's @> operator: | ||
| - Arrays: every element of candidate appears in target. | ||
| - Objects: every key in candidate exists in target with a matching value. | ||
| - Scalars: equality. | ||
| """ | ||
| if target_str is None or candidate_str is None: | ||
| return False | ||
| try: | ||
| target = json.loads(target_str) | ||
| candidate = json.loads(candidate_str) | ||
| except (json.JSONDecodeError, TypeError): | ||
| return False | ||
| return _contains(target, candidate) | ||
|
|
||
|
|
||
| def _contains(target: object, candidate: object) -> bool: | ||
| if isinstance(candidate, dict): | ||
| if not isinstance(target, dict): | ||
| return False | ||
| return all(k in target and _contains(target[k], v) for k, v in candidate.items()) | ||
| if isinstance(candidate, list): | ||
| if not isinstance(target, list): | ||
| return False | ||
| return all(any(_contains(t, c) for t in target) for c in candidate) | ||
| return target == candidate | ||
|
|
||
|
|
||
| async def install_json_functions(connection: aiosqlite.Connection) -> None: | ||
| await connection.create_function("json_contains", 2, _json_contains_impl) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be referencing postgresql implementation in sqlite contrib