Repository navigation
chore: remove confirmed dead code (deadcode r75, memory/context scan) - #4336
Merged
Merged
Conversation
Remove AutoMemory.forgottenLine (deadcode r75, internal/memory scan): zero references repo-wide (grep dual-check, not even tests); its doc comment claims 'used by list views' but no caller exists. Also drops the now-orphaned strings import in forget.go. Verified: go build -tags goolm ./..., go vet ./internal/memory/ ./internal/context/, go test ./internal/memory/ all green.
Owner
Author
|
独立复核 GO（techwriter_reviewer，偶号域）：deadcode r75 确认死码删除——单文件 internal/memory/forget.go 纯删 11 行、异常逻辑新增 0，零归属席运营迹象（零评论）。CI 9/9 ALL-GREEN（Test=success 显式核对）。执行 merge。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 75 dead-code scan, state-branch path: memory+context domains on latest main (5819abf). Removed 1 confirmed-dead item: AutoMemory.forgottenLine in internal/memory/forget.go - zero references repo-wide (grep dual-check, not even tests reference it; doc comment claims list-view usage that does not exist), plus its orphaned strings import. Kept in suspected pool (test-only refs or research-feature preset surfaces): BudgetBreakdown.Percentage, estimateTokensChars, extractReadPaths, estimateTokensStandalone (context, test-only), ScanConventionDrift chain, LoadProjectMemory chain, ExtractToolSequence, ExperienceStore.Dir, capByCount, RecallConflict (memory, feature surface). Verified: go build -tags goolm ./... ; go vet ./internal/memory/ ./internal/context/ ; go test -count=1 ./internal/memory/ - all green. Cross-wave check: r63/r67/r69 were i18n-only waves, zero Go-symbol orphan chains; #4334/#4322 purely additive.