Repository navigation
Conversation
The titlebar read "disktree · <dir>", so the only way to know which build was running was the terminal. It now reads "disktree 0.11.0 · <dir>", from CARGO_PKG_VERSION. Both places that set the title (the window options at launch and the render that follows navigation) go through one marks::window_title, so the two formats cannot drift apart. A unit test pins the format, and a window-harness test reads the real window title before and after Enter descends into a directory. Closes tobi#76 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lpalvess
force-pushed
the
show-version-in-title
branch
from
October 11, 2026 20:42
23f03b6 to
b63f28e
Compare
lpalvess
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The window title now includes the version:
disktree 0.11.0 · <dir>instead ofdisktree · <dir>. The version comes fromCARGO_PKG_VERSION, so it follows the workspace version.The title is built by one function,
marks::window_title, which both places that set it now use (opening the window inmain.rs, rendering instate.rs). Before, the format was written in both places.Testing
marks.rsfor the exact title, under a home directory and at the home directory itself.tests.rs: reads the real window title on open, presses Enter, and reads it again in the child directory. It fails without the change, and also if render stops callingset_window_title.cargo xtask lintandcargo xtask testpass on Linux (217 tests).Not checked by hand on macOS or Windows; the change is the title string only.
Closes #76
🤖 Generated with Claude Code