Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
Throwaway fixtures against origin/main's shared Git command wrapper (not included here) ran a configured external diff program and a configured textconv program and created marker files. Those diff forms occur in tests today, not in production status inspection. A further regression runs in a child environment with
GIT_CONFIG_COUNT=1,KEY_0=core.fsmonitorandVALUE_0set to a quoted marker script; it asserts the variables are removed and no marker appears.Fix
Pin safe inspection configuration, ignore global and system configuration, and disable optional locking and lazy fetch. Remove inherited command-scope configuration and the indexed
KEY/VALUEentries. Diff invocations use--no-ext-diff --no-textconv. Fixture setup ignores ambient configuration, quotes paths containing spaces or apostrophes, and checks real Git availability without triggering macOS install prompts. Corrects a stale comment about global filters. No new dependencies.Checks run
cargo xtask lintpassed.cargo xtask testpassed: 75 app, 140 core (2 ignored), 3 xtask. The inherited-config, external-diff and textconv regressions each passed (1 passed).Conflict with #59
Based on origin/main 6c8d4ce. #59 moves
crates/disktree-app/src/git.rsinto disktree-core, so this will conflict. If #59 lands first, port the shared hardened builder and its fixtures to the moved module; I'm happy to do that.Limitations
The adversarial fixtures ran on Linux only; Windows was not verified. The separate filter-preflight and status subprocesses keep a window for concurrent repository configuration changes, so this is not complete hostile-repository isolation.
Developed with AI assistance (OMP agents). I reviewed the diffs; every check listed was run on the final branch.