Skip to content

fix(tests): fix flaky test_capture_pane_flags[join_wrapped_numbers] #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tony wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(tests): fix flaky test_capture_pane_flags[join_wrapped_numbers] #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
810bbf4
fix(tests): fix flaky test_capture_pane_flags[join_wrapped_numbers]
tony Apr 1, 2026
0cecae7
docs(CHANGES) flaky join_wrapped_numbers test fix
tony Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ $ uvx --from 'libtmux' --prerelease allow python
_Notes on the upcoming release will go here._
<!-- END PLACEHOLDER - ADD NEW CHANGELOG ENTRIES BELOW THIS LINE -->

### Bug fixes

- Fix flaky `test_capture_pane_flags[join_wrapped_numbers]` — marker detection now
skips the shell command echo line to avoid false-positive completion (#655)

## libtmux 0.55.0 (2026-03-07)

### What's new
Expand Down
8 changes: 5 additions & 3 deletions tests/test_pane_capture_pane.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,12 @@ def prompt_ready() -> bool:
full_command = f'{command}; echo "{marker}"'
pane.send_keys(full_command, literal=False, suppress_history=False)

# Wait for marker to appear
# Wait for marker to appear as command output (not in the command echo line)
def command_complete() -> bool:
output = "\n".join(pane.capture_pane())
return marker in output
lines = pane.capture_pane()
return any(
marker in line and not line.lstrip().startswith("$") for line in lines
)

retry_until(command_complete, 5, raises=True)

Expand Down
Loading