feat: ✨Implement azdo pipelines queue list command#303
Merged
Conversation
Introduce map-based EnumLookup[T] with Keys, GetValue, and GetValuePtr methods. Uses maps/slices for sorted keys and adds trimming/lower-casing plus pointer variants for improved enum handling.
- Extract common registration and validation logic into shared helpers (`registerEnumFlag`, `validateEnumValue`). Introduce `nullableEnumValue` and `nullableEnumMultiValue` types so callers can now use optional (enum) flags via the new `NilStringEnumFlag` and `NilStringSliceEnumFlag` functions, matching the existing `Nil*` pattern for strings and bools. - Add thorough unit tests covering the new helpers plus the pre-existing nil-flag and enum-flag functions.
…t filters Switch filter options from slices to *string pointers (branch, status, result, reason, requestedFor, queryOrder). Adopt util.NilStringFlag and NilStringEnumFlag helpers for flag registration. Replace the old allBuild* slices with typed EnumLookup maps and update lookup/assignment logic accordingly. Move ios.StopProgressIndicator calls under a defer and clean up error paths. Add ParseFlags tests for valid/invalid enum values and drop the now-redundant runtime invalid-filter tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249