Repository navigation
--cache-right: never replay a hang, keep POST bodies, flag live misses - #23
Merged
Merged
Conversation
Drops cancelled (-1) entries along with errors, keys entries by request body too, and lists requests the recording lacks as a failed asset on the right so a half-live reference is never clean or reused. Blocks service workers on both sides while caching, writes the recording 0600 with a .gitignore, and prints both right: lines when a rerun replays and records. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the review of #21.
status: -1) were kept in the recording, and Playwright replays them as a request that never settles. A recorded stylesheet hunggotountil timeout. Only 200–399 is kept now.N request(s) not in the recording, loaded liveunderfailedon the right. A half-live reference is never clean and--rerun-faileddoesn't reuse it. Checked by hand: removing the stylesheet from a recording givesfailed right: 1 request(s) not in the recording, loaded live.--cache-rightis on (a HAR can't see what they serve)..gitignore(*) beside it, since it holds the right side's cookies and auth headers.--rerun-failed --cache-right, bothright:lines print when a run replays and also records.Not done:
--accept+--cache-rightis still allowed; deleting expired recordings is left to the next wipe.Unit 232/232 and visual 306/306 pass locally.
🤖 Generated with Claude Code