Repository navigation
Harden the action and the release before 0.3.2 - #22
Merged
Merged
Conversation
Action: wait inside the run step with a curl timeout so a down origin reports exit-code 2, --flag=value for every input, artifact name via env, Node 24 without package-manager cache, Chromium cached on every OS. Release: publish keeps contents: read; a separate job moves v0, only for v0.x without a prerelease suffix. Self-test asserts /tint and the down case. Docs: threshold and half-pixel note, re-accept after upgrading, protection and production deployments, running twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the review of #19 and #20.
action.yml
leftruns inside the run step withcurl --max-time 10and a numeric check onwait-timeout, so a down origin setsexit-code=2and gets a summary instead of a bare failure.--flag=value, so anacceptreason or path starting with-isn't refused.artifact-namegoes throughenv(it was interpolated into the script).package-manager-cache: false. Chromium goes toPLAYWRIGHT_BROWSERS_PATHunder the tool cache, so the cache works on macOS and Windows too.release.yml
publishkeepscontents: read. A separatemove-v0job withcontents: writemovesv0and can be rerun alone. It runs only forv0.xtags without a prerelease suffix.Self-test
/colorand/tintscore below the threshold, that the accepted file names/color, and that an unreachableleftgivesexit-code2.Docs
deployment_status, running twice or in a matrix,outoverridingoutDir, and the Node 24 side effect.Not done: a half-pixel fixture asserting a known small score; it's documented instead.
🤖 Generated with Claude Code