Repository navigation
Report failed stylesheets and fonts; skill hints for upgrades - #16
Merged
Merged
Conversation
- Record per side the stylesheets that failed or answered >= 400 (blocked URLs aside) and the font faces in error; shown as a `failed` line under the row, on the report card and in results.json. - Cap the wait on document.fonts.ready at 5s. - Skill: allowed-tools for the renderdiff CLI; read `failed` first; pre-upgrade worktree as the reference, production builds over dev overlays, one route per template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Clear the failures per load in capture(), not on framenavigated, which a same-document pushState during hydration fires too. - Ignore net::ERR_ABORTED: the page or the next navigation cancelled it. - Keep the query in stylesheet URLs (Google Fonts css2?family=…). - A shot with a failed asset is neither clean nor reused by --rerun-failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideas taken from pixel-by-pixel, page-compare and visual-regression-upgrade.
Tool
status === "error". Requests aborted byblockUrlPatternsdon't count. This catches the classic false regression where a font CDN refuses localhost and the whole page reflows into the fallback font.failed left: …; right: …line under the row, beforedom.--progressand the report card show it too.results.jsongetsfailed: { left, right }.document.fonts.readyis now capped at 5s; before it had no limit.Skill
allowed-toolsfor the renderdiff CLI, so the loop doesn't stop at a permission prompt on every run.failedfirst.git worktreeas the reference.Tests
broken-assetguard-rail fixture: a 404 stylesheet, a blocked stylesheet and a 404 font face on both sides.🤖 Generated with Claude Code