feat: add resolve cmd#1236
Conversation
0d3a852 to
2f8c5f6
Compare
There was a problem hiding this comment.
Thank you for the pull request - just a few general questions, assuming all maintainers agree on adding this feature: #1234 (comment)
- Is it required to ignore files outside the working directory to "avoid overload"? In my opinion this is unintuitive and I don't think it causes overload: the command should behave the same no matter where the user is in the git repository.
- I assume the
git diff --checkensures that no files with conflict markers are committed. However, it looks like it also checks if there are whitespace errors. I worry that for some user-supplied files, a "whitespace error" (false positive) will always be activated, is there some way to avoid this?
Code comments:
- I don't think many other bash programs in this repository set
IFSto$' \t', so I would prefer if this file would be consistent with that. - Would removing the
git continueat the bottom avoid the potential pitfall that you mention? I think it would be better to not rungit continuein general and let the user do it when they are ready.
Not really, it's a preventive measure in case there are too many conflicted files. It ensures
I have the same concern. I haven't tested, but this command should work as alternative: git -c core.whitespace='' diff --check
IIRC, yes
I agree. I can remove it now. It can be re-added in the future if a workaround for |
closes #1234
Note
I'll
push -fonly while indraftstate, to add missing docs