fix: EnumerationType member signedness (Type.Signed + ConvertInteger)#23
Merged
Conversation
Python's EnumerationType.members reinterprets each member's raw u64 per the type's signedness and width (binaryninja.types.convert_integer), so a signed enum reports -1 for 0xFFFFFFFFFFFFFFFF. The C# binding only exposed the raw EnumerationMember.Value (ulong), so signed enumerations appeared as huge unsigned numbers. - Type.Signed: wrap BNIsTypeSigned (BoolWithConfidence). Width already existed. - EnumerationType.GetMemberSignedValues(): return each member value run through the width-mask + signed-reinterpret conversion that mirrors convert_integer. The raw EnumerationMember.Value stays ulong (the low-level C value); the signed view is opt-in via the parity method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python's
EnumerationType.membersreinterprets each member's raw u64 per the type's signedness and width (binaryninja.types.convert_integer), so a signed enum reports-1for0xFFFFFFFFFFFFFFFF. The C# binding only exposed the rawEnumerationMember.Value(ulong), so signed enumerations appeared as huge unsigned numbers.Type.Signed— wrapsBNIsTypeSigned(BoolWithConfidence).Widthalready existed.EnumerationType.GetMemberSignedValues()— returns each member value run through the width-mask + signed-reinterpret conversion that mirrorsconvert_integer. The rawEnumerationMember.Valuestaysulong(the low-level C value); the signed view is opt-in via the parity method.The minimal durable-layer fix per the parity audit (the alternative — changing
EnumerationMember.Valueto a signed type — would break existing API).Verification
EnumerationBuilderand assertGetMemberSignedValuessign-extends (0xFF..F → -1for width 1 and 8) while preserving a small unsigned value.EnumerationMember.Value(raw) is checked alongside.