fix: DisassemblyTextLine/LinearDisassemblyLine Equals(object) cast#21
Merged
Conversation
Copy-paste defect from InstructionTextToken: both Equals(object?) overloads cast the other operand with `rawOther as InstructionTextToken`, which is always null for these types, so equality always returned false (and passing an InstructionTextToken recursed into its Equals(object)). Each must cast to its own type and delegate to the typed Equals. The typed Equals(T?) and the == / != operators were already correct. Mirrors Python's DisassemblyTextLine.__eq__ (function.py:3801) which compares the rendered line fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copy-paste defect carried over from
InstructionTextToken: bothEquals(object?)overloads cast the other operand withrawOther as InstructionTextToken, which is always null for these struct types, so equality always returned false (and passing anInstructionTextTokenrecursed into its ownEquals(object)). Each must cast to its own type and delegate to the typedEquals. The typedEquals(T?)and the==/!=operators were already correct.Struct/BNDisassemblyTextLine.cs:133—as InstructionTextToken→as DisassemblyTextLineStruct/BNLinearDisassemblyLine.cs:91—as InstructionTextToken→as LinearDisassemblyLine(
Struct/BNInstructionTextToken.cs:187correctly casts toInstructionTextToken— left untouched.)Mirrors Python's
DisassemblyTextLine.__eq__(function.py:3801) which compares the rendered-line fields.Verification
trueviaEquals(object)and a different line comparesfalse. Before the fixEquals(object)always returnedfalse.