Skip to content

fix: BinaryReader 64-bit endianness + base-class generic #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tinysec merged 1 commit into from
Jul 8, 2026
Merged

fix: BinaryReader 64-bit endianness + base-class generic #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Handle/BNBinaryReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace BinaryNinja
{
public sealed class BinaryReader : AbstractSafeHandle<Architecture>
public sealed class BinaryReader : AbstractSafeHandle<BinaryReader>
{
public BinaryReader(BinaryView view)
: this(NativeMethods.BNCreateBinaryReader(view.DangerousGetHandle()) , true)
Expand Down Expand Up @@ -243,7 +243,7 @@ public bool ReadData(byte[] buffer)

public long? ReadInt64()
{
bool ok = NativeMethods.BNReadLE64(this.handle, out ulong slug);
bool ok = NativeMethods.BNRead64(this.handle, out ulong slug);

if (!ok)
{
Expand Down Expand Up @@ -374,7 +374,7 @@ public bool ReadData(byte[] buffer)

public ulong? ReadUInt64()
{
bool ok = NativeMethods.BNReadLE64(this.handle, out ulong slug);
bool ok = NativeMethods.BNRead64(this.handle, out ulong slug);

if (!ok)
{
Expand Down
Loading