Skip to content

DOC-3243: Directionality buttons now always apply to blocks and only appear active when directionality is set#4033

Open
kemister85 wants to merge 1 commit intofeature/8.4.0/DOC-3243from
feature/8.4.0/DOC-3243_TINY-13337
Open

DOC-3243: Directionality buttons now always apply to blocks and only appear active when directionality is set#4033
kemister85 wants to merge 1 commit intofeature/8.4.0/DOC-3243from
feature/8.4.0/DOC-3243_TINY-13337

Conversation

@kemister85
Copy link
Contributor

@kemister85 kemister85 commented Mar 18, 2026

Ticket: DOC-3243

Site: Staging

Changes:

  • Added release note entry for TINY-13337 to modules/ROOT/pages/8.4.0-release-notes.adoc

Pre-checks:

  • Branch is correctly prefixed (release-note branch)
  • modules/ROOT/nav.adoc has been updated (if applicable).
  • Files have been included where required (if applicable).
  • Files removed have been deleted, not just excluded from the build (if applicable).
  • Files added for New product features include a release note entry.
  • Major or minor version changes have updated the supported-versions.adoc table.
  • Build passes without console errors, warnings, or issues.

Review:

  • Documentation Team Lead has reviewed.

…d only appear active when directionality is set
@kemister85 kemister85 requested review from a team and soritaheng as code owners March 18, 2026 02:16
@kemister85 kemister85 requested review from EkimChau, ShiridiGandham and tiny-james and removed request for a team March 18, 2026 02:16
@kemister85 kemister85 added the upcoming release Documentation for features currently under development/QA label Mar 18, 2026
@kemister85 kemister85 added this to the TinyMCE 8.4.0 milestone Mar 18, 2026
@kemister85 kemister85 requested a review from MitchC1999 March 18, 2026 02:17
@kemister85
Copy link
Contributor Author

kemister85 commented Mar 18, 2026

@MitchC1999 Consolidated both .yaml entries into one for this.

Comment on lines +120 to +122
Previously, the directionality buttons only applied the directionality attribute or style to the current block when toggling to the opposite of the default directionality. Clicking the button for the default directionality had no effect, and the toolbar could show an active button even when the block itself had no explicit directionality set.

In {productname} {release-version}, each directionality button always applies or removes the directionality attribute on the selected block, and only appears active when directionality is explicitly set on the block.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Previously, the directionality buttons only applied the directionality attribute or style to the current block when toggling to the opposite of the default directionality. Clicking the button for the default directionality had no effect, and the toolbar could show an active button even when the block itself had no explicit directionality set.
In {productname} {release-version}, each directionality button always applies or removes the directionality attribute on the selected block, and only appears active when directionality is explicitly set on the block.
Previously, the directionality buttons would not apply the directionality attribute or style when toggling to the default directionality. This could cause non-default directional content to appear in the opposite direction.
In {productname} {release-version}, each directionality button always applies or removes the directionality attribute on the selected block, and only appears active when directionality is explicitly set on the block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upcoming release Documentation for features currently under development/QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants