DOC-3243: Directionality buttons now always apply to blocks and only appear active when directionality is set#4033
Open
kemister85 wants to merge 1 commit intofeature/8.4.0/DOC-3243from
Conversation
…d only appear active when directionality is set
Contributor
Author
|
@MitchC1999 Consolidated both |
MitchC1999
approved these changes
Mar 19, 2026
Comment on lines
+120
to
+122
| Previously, the directionality buttons only applied the directionality attribute or style to the current block when toggling to the opposite of the default directionality. Clicking the button for the default directionality had no effect, and the toolbar could show an active button even when the block itself had no explicit directionality set. | ||
|
|
||
| In {productname} {release-version}, each directionality button always applies or removes the directionality attribute on the selected block, and only appears active when directionality is explicitly set on the block. |
Contributor
There was a problem hiding this comment.
Suggested change
| Previously, the directionality buttons only applied the directionality attribute or style to the current block when toggling to the opposite of the default directionality. Clicking the button for the default directionality had no effect, and the toolbar could show an active button even when the block itself had no explicit directionality set. | |
| In {productname} {release-version}, each directionality button always applies or removes the directionality attribute on the selected block, and only appears active when directionality is explicitly set on the block. | |
| Previously, the directionality buttons would not apply the directionality attribute or style when toggling to the default directionality. This could cause non-default directional content to appear in the opposite direction. | |
| In {productname} {release-version}, each directionality button always applies or removes the directionality attribute on the selected block, and only appears active when directionality is explicitly set on the block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-3243
Site: Staging
Changes:
modules/ROOT/pages/8.4.0-release-notes.adocPre-checks:
Branch is correctly prefixed(release-note branch)modules/ROOT/nav.adochas been updated (if applicable).Files removed have been deleted, not just excluded from the build (if applicable).Files added for New product features include arelease noteentry.Major or minor version changes have updated thesupported-versions.adoctable.Review: