Skip to content

DOC-3243: Cancel button would always focus when the view opened, even when editor wasn't focused.#4024

Open
kemister85 wants to merge 1 commit intofeature/8.4.0/DOC-3243from
feature/8.4.0/DOC-3243_TINY-13711
Open

DOC-3243: Cancel button would always focus when the view opened, even when editor wasn't focused.#4024
kemister85 wants to merge 1 commit intofeature/8.4.0/DOC-3243from
feature/8.4.0/DOC-3243_TINY-13711

Conversation

@kemister85
Copy link
Contributor

@kemister85 kemister85 commented Mar 16, 2026

Ticket: DOC-3243

Site: Staging

Changes:

  • Added release note entry for TINY-13711 to modules/ROOT/pages/8.4.0-release-notes.adoc (Accompanying Premium plugin changes section): Cancel button would always focus when the view opened, even when editor wasn't focused.

Pre-checks:

  • Branch is correctly prefixed (release-note branch)
  • modules/ROOT/nav.adoc has been updated (if applicable).
  • Files have been included where required (if applicable).
  • Files removed have been deleted, not just excluded from the build (if applicable).
  • Files added for New product features include a release note entry.
  • Major or minor version changes have updated the supported-versions.adoc table.
  • Build passes without console errors, warnings, or issues.

Review:

  • Documentation Team Lead has reviewed.

@kemister85 kemister85 requested review from a team and soritaheng as code owners March 16, 2026 06:18
@kemister85 kemister85 requested review from EkimChau, MitchC1999 and tiny-james and removed request for a team March 16, 2026 06:18
@kemister85 kemister85 added the upcoming release Documentation for features currently under development/QA label Mar 16, 2026
@kemister85 kemister85 added this to the TinyMCE 8.4.0 milestone Mar 16, 2026
// #TINY-13711

// CCFR here.
Previously, the Cancel button in Suggested Edits was automatically focused whenever the review was opened, including when the review opened automatically on load. When the editor was positioned lower on the page, the browser would scroll the focused button into view, causing unexpected page scrolling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Previously, the Cancel button in Suggested Edits was automatically focused whenever the review was opened, including when the review opened automatically on load. When the editor was positioned lower on the page, the browser would scroll the focused button into view, causing unexpected page scrolling.
Previously, the Cancel button in Suggested Edits was automatically focused whenever the review was opened, including when the review opened automatically on load. This could cause unexpected scrolling behaviour, such as when an editor is positioned further down the page, the browser would scroll the editor into view when the page loads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upcoming release Documentation for features currently under development/QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants