Fix to allow -o flag to point to a directory :: #5548 - #5569
Merged
Conversation
Previously, running 'tinygo build -o dist/ file.go' where dist/ already exists as a directory failed with 'open dist/: is a directory', because Build() only auto-derived a binary name when outpath was empty, not when it pointed to an existing directory. This adds that check, matching the behavior of 'go build -o dir/' with a package. Note: only handles the case where the directory already exists; if the directory doesn't exist yet, behavior is unchanged.
asadkhanbn600i
changed the title
asadkhanbn600i
changed the title
Contributor
Author
|
Hi @dgryski I don’t have merge access, Can you please merge it on my behalf. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes
tinygo build -o <dir>/ ...failing withopen <dir>/: is a directorywhen the target directory already exists.
Why
Build()in main.go only derived a default binary name whenoutpath == "".If
outpathwas explicitly set but pointed to an existing directory, thecode fell straight to
os.Rename(result.Binary, outpath), which failssince a directory can't be renamed-over/opened as a file.
Fix
Added a check: if
outpathis a directory, derive the same default binaryname used in the empty-outpath case, and place the binary inside that
directory — mirroring how
go build -o dir/behaves for a package.Scope
Only handles the case where the directory already exists. If
-o somedir/is given and
somedirdoesn't exist yet, behavior is unchanged. Happy toextend this in a follow-up if maintainers want that too.
Testing
make testpasses locally(unchanged), and no
-oflag (unchanged)