Repository navigation
Require tiny-blocks/http 8.0. - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer.jsonrequirestiny-blocks/http^8.0(was^7.2). 8.0 validates every header that reaches a response, rejects the connection-specific ones and restricts the protocol version to1.0,1.1,2and3(tiny-blocks/http#74).TinyBlocks\Http\Server\Requestand logs the response the next handler returns without building or altering one, so it sets no header and no protocol version that 8.0 refuses.CI
CI resolves
tiny-blocks/http^8.0from Packagist, so it stays red untiltiny-blocks/http8.0.0is published. Merge after that release and a green re-run. Locally,make reviewandmake testspass against the 8.0 branch oftiny-blocks/httpinstalled through a temporary, uncommitted path repository (50 tests, 52 mutants, MSI 100%).Release
Recommended release:
1.4.0(minor). The public API exposes notiny-blocks/httptype:LogMiddlewareand its builder speak PSR-7, PSR-15, PSR-3 andtiny-blocks/time(MonotonicClock), andRequestis used only insideInternal/. A consumer's code compiles and behaves the same, and Composer only lets the release install wheretiny-blocks/http8 can be installed. The minor marks the raised dependency floor.Related issue
None.
Checklist
make reviewpasses.make testspasses.