This repository was archived by the owner on Dec 28, 2022. It is now read-only.
Group albums into artists regardless of artist name capitalisation#498
Open
whimsicalities wants to merge 2 commits intotimusus:devfrom
Open
Group albums into artists regardless of artist name capitalisation#498whimsicalities wants to merge 2 commits intotimusus:devfrom
whimsicalities wants to merge 2 commits intotimusus:devfrom
Conversation
|
|
Owner
|
I'll have to review this one in depth, as I'm not sure what the consequences of this change are. |
|
I second this. This will group artists like Tesseract (often stylized as TesseracT) into one. |
|
this would be a disadvantage if you are careful with your tagging, but have more than one artist with the same name that you are trying to order through different capitalization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This discards capitalisation when making a list of AlbumArtists, stopping it from separating inconsistent artists into several AlbumArtists. It will still show the correct capitalisation on the display.
I also included the update to the glide version that was causing the build to fail.
closes #497 closes #491