Prevent bun installer from modifying shell config#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
bunbootstrap script downloads and runs the official bun installer (https://bun.sh/install). That installer has an unwanted side-effect: it appendsBUN_INSTALLandPATHexports to the user's shell config (~/.bashrc,~/.zshrc, orconfig.fish).Investigation
The installer has no dedicated flag/env var to disable shell-config modification. The behavior is gated by a
case $(basename "$SHELL")switch — it only appends to a config file when the shell basename matchesfish,zsh, orbash. The default*)branch merely prints manual instructions and writes nothing.Fix
Pass
SHELL=""when piping into the installer so itscasefalls through to the harmless default branch. Since the wrapper always invokes bun via its explicit path, thePATHexports were never needed anyway.