chore: fix overlap check in pointcloud metainfo validator#268
Merged
Conversation
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the pointcloud metadata validation logic where sources with zero length incorrectly triggered validation errors. The fix ensures that sources representing zero points are excluded from the interval-based coverage validation while still validating their bounds.
Changes:
- Modified
_validate_metainfomethod to skip sources withlength == 0when building intervals for coverage validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted improvement to the
_validate_metainfomethod inpointcloud.pyto handle a specific edge case during point cloud metadata validation.Validation logic improvement:
_validate_metainfoint4_devkit/dataclass/pointcloud.pyto skip sources with zerolengthwhen building intervals, preventing failures in the non-overlapping check for sources that don't represent any points.