feat(schema): update schema of surface_ann.json#252
Closed
ktro2828 wants to merge 2 commits into
Closed
Conversation
github-actions
Bot
added
bug
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the SurfaceAnn schema to support instance and attribute references, making the schema more flexible for complex annotation data. The changes align with related work in tier4_perception_dataset pull request #278.
Changes:
- Added optional
instance_tokenandattribute_tokensfields toSurfaceAnnschema - Made the
maskfield optional in the schema - Updated test fixtures to include the new fields
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| t4_devkit/schema/tables/surface_ann.py | Added instance_token and attribute_tokens fields to the schema, made mask optional |
| tests/schema/conftest.py | Updated surface_ann_dict test fixture with new fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ktro2828
changed the title
ktro2828
force-pushed
the
fix/schema/surface-ann
branch
2 times, most recently
from
743e1e2 to
92aeb32
Compare
github-actions
Bot
added
the
documentation
ktro2828
added
new-feature
ktro2828
changed the title
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
ktro2828
force-pushed
the
fix/schema/surface-ann
branch
from
a71f2a0 to
612fd15
Compare
SamratThapa120
approved these changes
Feb 4, 2026
Contributor
SamratThapa120
left a comment
SamratThapa120
left a comment
There was a problem hiding this comment.
LGTM thanks.
It is okay as a different PR, but we should add sanity check to ensure instance_token and attribute_token refers to records in the Instance and Attribute tables.
Collaborator
Author
|
NOTE: Merge this PR to #249. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR is related to tier4/tier4_perception_dataset#278.
This pull request extends the
SurfaceAnnschema to support additional annotation details, specifically instance and attribute references, and updates related test fixtures accordingly. These changes improve the schema's flexibility for representing more complex annotation data.Schema enhancements:
instance_token(optional string) andattribute_tokens(optional list of strings) fields to theSurfaceAnnschema to allow referencing instance and attribute categories. [1] [2]maskfield inSurfaceAnnoptional to align with the new schema flexibility. [1] [2]Test updates:
surface_ann_dicttest fixture to include the newinstance_tokenandattribute_tokensfields, ensuring tests cover the extended schema.