Skip to content

Add check function for named-ness - #6766

Merged
teunbrand merged 4 commits into
tidyverse:mainfrom
teunbrand:check_named
Dec 16, 2025
Merged

Add check function for named-ness#6766
teunbrand merged 4 commits into
tidyverse:mainfrom
teunbrand:check_named

Conversation

@teunbrand

Copy link
Copy Markdown
Collaborator

This PR does not fix a posted issue.

I'd like this check function to use in #6196. I'm filing this PR separately, because it has the potentially breaking change of disallowing duplicate arguments to ggproto().

Comment thread R/stat-bindot.R
return(data)
},

dropped_aes = c("weight", "bin", "bincenter")

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding this check to ggproto(), I found that this was a duplicated entry.

@thomasp85 thomasp85 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand
teunbrand merged commit 3c21288 into tidyverse:main Dec 16, 2025
13 checks passed
@teunbrand
teunbrand deleted the check_named branch December 16, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants