Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registrations. Engine arguments are now registered with
parsnip::set_model_arg(), replacing the customtunable.C5_rules()andtunable.cubist_rules()methods (andc5_rules_engine_args/add_engine_parameters()).C5_rules()/ C5.0:CF(confidence_factor()),noGlobalPruning(no_global_pruning()),winnow(predictor_winnowing()),fuzzyThreshold(fuzzy_thresholding()),bands(rule_bands()).cubist_rules()/ Cubist:extrapolation(extrapolation()),unbiased(unbiased_rules()).trees:c(1, 100).min_n:c(2, 40).committees:c(1, 100).neighbors:c(0, 9).The engine arguments now always appear in
tunable()withcomponent_id = "engine", as with other parsnip engines. Previously they appeared only if one was already markedtune().Bug fix in
c5_fit(). Engine arguments such asCForwinnowwere passed toC50::C5.0()directly, which ignores them, so tuning them had no effect. They are now put intoC50::C5.0Control().controlargument is now actually modified (minCases, default seed,earlyStopping = FALSE). Previously the modification was applied to the quosure and lost.controland control arguments now errors.Test fix. The Cubist "argument/call assembly" tests now derive their expected control lists from
Cubist::cubistControl(). They had hard-coded the fields, and failed onmainonce Cubist addedstrip_time_stamps.