Repository navigation
Conversation
Dialog content is fixed-centered with no height limit, so a long skill body (the textarea uses field-sizing-content) grows the dialog past the viewport and the footer actions end up unreachable because the page itself does not scroll. Cap the shared dialog at the viewport height with internal scrolling. This also fixes other long-form dialogs (e.g. the memory editor) in one place. Closes tickernelz#429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #429
The shared dialog is fixed-centered with no height limit, so a long skill body (the
skill-contenttextarea usesfield-sizing-content) grows the dialog past the viewport while the page itself does not scroll — the Save button ends up unreachable.This caps the shared
Dialogcontent at the viewport height with internal scrolling (max-h-[calc(100dvh-2rem)] overflow-y-auto), matching themax-w-[calc(100%-2rem)]pattern already used for width. Fixing it indialog.sveltecovers every dialog (skill editor, memory editor, cleanup/migration dialogs) in one place.Measured on the Skills → Create Skill dialog with a ~1.7k-char skill body at viewport 1280x800:
Test plan
bun run dev:sim(sim data, no real memories touched), verified before/after geometry above, clicked Save end-to-end (dialog closes, skill saved)bun testfailures on my machine (config/embedding-prefix/profile-runtime) come from local user config leaking into the test env (CONFIG.embeddingPoolingresolves tolast_tokenvia the installed model preset instead of the expectedmean); none importweb/and none are touched by this change.bun testafterbun run build: 828 pass / 7 fail / 6 skip.Checklist
main(do not open PRs from commits already onmain)bun testpasses (or N/A) — see pre-existing failures noted abovebun run typecheckpasses (or N/A)bun run checkpasses (format + lint + typecheck; or N/A)cd web && bun run check(svelte-check): 0 errors, 0 warnings