Repository navigation
Fix minimatch denial of service advisory (GHSA-g3hv-75wg-m249) - #13
Merged
Merged
Conversation
Scope the override to app-builder-lib and its @electron/universal subtree so ESLint and dir-compare keep minimatch 3.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Dependabot alert #17.
Change
overridesentry inpackage.jsonthat setsminimatchto 11.0.1 forapp-builder-liband its@electron/universalsubtree.dir-compareinside that subtree tominimatch3.1.5, which it needs.package-lock.json.minimatchis a development-only dependency pulled in byelectron-builder. The latestelectron-builder(26.18.0) still depends on the vulnerable range (>= 7.0.0, < 11.0.1), so a version bump alone does not fix it. ESLint and its related packages keepminimatch3.1.5, which is outside the affected range.Verification
Run locally before pushing:
npm auditno longer reportsminimatch.npm run cipasses (lint, format check, 170 tests, packaging check).electron-builder --dircompletes and produces the unpacked app.npm auditstill reportselectronandfast-uri. Those are unrelated and not changed here.