fix(message-reader): inlined image not displaying#11082
Conversation
github-actions
Bot
added
the
tb-team
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
rafaeltonholo
requested review from
dani-zilla
and removed request for
jbott-tbird
rafaeltonholo
changed the title
rafaeltonholo
force-pushed
the
fix/10889/inlined-image-not-displaying-message-reader
branch
from
d16545d to
108e11f
Compare
|
Sometimes I could get inline images, but other times they appear below. I'm trying to figure out when this happens, but I think it could be down to your account settings, if you always allow images. With this account, I have it set to always allow images, yet the photo I sent ended up below the email, with a divider line where the image should have been between the text. That's not to say it doesn't always work: |
Looking into this now and I'll come up with a more detailed test plan, but what I found so far is that it is interpreted as a jpeg mimetype and should display. I'll try to piece out which cases fail or if it's from a specific email service. |
Might have figured out at least one issue. It's not putting the image inline if it's downsized by the email sender. I used my mail client to downsize this image to "Small" when sending so it wouldn't hit the kb threshold for being too large and requiring a separate download.
Also, I found another issue with displaying inline images that are too large. When you download the image and it re-draws to display the image inline, it's HUGE. Too large to fit in the view area. It will either shrink the text to display the entire image if the user has selected the "Auto-fit messages" option in Settings > General > Display. If auto-fit messages is off, it's just a huge image. We may want to consider auto-scaling such images, but perhaps that's out of scope for this fix, as I do believe that was the behavior before we encountered this bug. |
…ttachment view data - Add `AttachmentUiItem` sealed interface with subtypes: `RemoteImage`, `InlinedImage`, `File`, `InlinedFile` - Add `AttachmentViewInfoMapper` interface for bidirectional mapping between domain and UI layers - Implement `DefaultAttachmentViewInfoMapper` in legacy core with `AttachmentViewInfo` implementing `AttachmentMetadata` - Change `message-reader-api` and `message-reader-impl` to use `kmpCompose` plugin - Add temporary methods to `AttachmentMetadata` to avoid breaking changes with `@JvmField` properties
Could you please share with me the
I will create a separate issue to investigate this matter. Resizing images in this way would require JavaScript integration, which is disabled in our webview. |
rafaeltonholo
force-pushed
the
fix/10889/inlined-image-not-displaying-message-reader
branch
from
108e11f to
eb92f25
Compare
…legacy MessageContainerView - Add `MessageReaderViewModel` to manage attachment state - Introduce `MessageReaderViewContract` with `State`, `Event`, and `ViewModel` abstraction - Create `AttachmentCard` composable for rendering attachment UI - Integrate `AttachmentViewInfoMapper` to map legacy `AttachmentViewInfo` to `AttachmentUiItem` - Add `MailPart` expect/actual interface to bridge platform-specific attachment types - Wire up attachment rendering in `MessageContainerView.renderAttachments()` using ComposeView - Register `MessageReaderViewModel` in Koin DI with `koin-core-viewmodel` - Add comprehensive unit tests for `MessageReaderViewModel` attachment mapping and filtering logic
…view all attachments
…ssues with koinViewModel - Set ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed on attachment ComposeView - Inject MessageReaderViewModel at fragment level and pass it down to MessageContainerView instead of using koinViewModel inside ComposeView
rafaeltonholo
force-pushed
the
fix/10889/inlined-image-not-displaying-message-reader
branch
from
eb92f25 to
5e3b7a1
Compare
|
I really don't know what to say. I've sent dozens of emails to myself from a variety of accounts. iCloud, Gmail, Thundermail, Proton. I used the Thunderbird desktop client, Gmail on the web, my mail app, the Thunderbird app (can't do inline attachments anyway), and Apple's Mail app on iOS. With the exception of Proton on Android, they all showed up with the inline image at the bottom and a divider line where the image should be. I think it may have to do with what they send through, how they denote its place in the email, whether or not they did resizing with or without my permission, I don't know. How are you testing that you're not seeing similar results? |
3 participants
Contribution Summary
Fixes: #10889
Description
This PR brings back the attachment list at the bottom of the message. Instead of just reverting the removal of the old one, I've implemented a new one using Compose, since it will be useful in the future when we migrate the Message Reader to Compose.
Changes included:
AttachmentViewInfoto KotlinBoxScopetoRemoteImageViewbutton.Screenshots
AI Disclosure
Select one of the following (mandatory)