Skip to content

Drop ID token from Nuxt session cookie to fix oversized-cookie login failure #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janithjay wants to merge 1 commit into from
+2 −27
Closed

Drop ID token from Nuxt session cookie to fix oversized-cookie login failure #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/nuxt/src/runtime/server/utils/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ export async function createSessionToken(
/** Unix timestamp (seconds) when the access token expires. */
accessTokenExpiresAt?: number;
expirySeconds?: number;
/** Raw ID token string. */
idToken?: string;
organizationId?: string;
/** Refresh token for silent re-auth. */
refreshToken?: string;
Expand All @@ -58,7 +56,6 @@ export async function createSessionToken(
return new SignJWT({
accessToken: params.accessToken,
accessTokenExpiresAt: params.accessTokenExpiresAt,
idToken: params.idToken,
organizationId: params.organizationId,
refreshToken: params.refreshToken,
scopes: params.scopes,
Expand Down Expand Up @@ -201,7 +198,6 @@ export async function issueSessionCookie(
{
accessToken: tokenResponse.accessToken,
accessTokenExpiresAt,
idToken: tokenResponse.idToken || undefined,
organizationId,
refreshToken: tokenResponse.refreshToken || undefined,
scopes: tokenResponse.scope || '',
Expand Down
25 changes: 2 additions & 23 deletions packages/nuxt/tests/unit/session-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ describe('createTempSessionToken / verifyTempSessionToken', () => {
});
});

describe('createSessionToken — Phase 2 fields (accessTokenExpiresAt / refreshToken / idToken)', () => {
describe('createSessionToken — Phase 2 fields (accessTokenExpiresAt / refreshToken)', () => {
it('round-trips accessTokenExpiresAt', async () => {
const expiresAt = Math.floor(Date.now() / 1000) + 3600;
const token = await createSessionToken(
Expand All @@ -158,7 +158,6 @@ describe('createSessionToken — Phase 2 fields (accessTokenExpiresAt / refreshT
const payload = await verifySessionToken(token, TEST_SECRET);
expect(payload.accessTokenExpiresAt).toBe(expiresAt);
expect(payload.refreshToken).toBeUndefined();
expect(payload.idToken).toBeUndefined();
});

it('round-trips refreshToken', async () => {
Expand All @@ -177,24 +176,7 @@ describe('createSessionToken — Phase 2 fields (accessTokenExpiresAt / refreshT
expect(payload.refreshToken).toBe('rt_test_value');
});

it('round-trips idToken', async () => {
const fakeIdToken = 'header.payload.signature';
const token = await createSessionToken(
{
accessToken: 'at',
userId: 'u',
sessionId: 's',
scopes: 'openid',
idToken: fakeIdToken,
},
TEST_SECRET,
);

const payload = await verifySessionToken(token, TEST_SECRET);
expect(payload.idToken).toBe(fakeIdToken);
});

it('round-trips all three Phase 2 fields together', async () => {
it('round-trips Phase 2 fields together', async () => {
const expiresAt = Math.floor(Date.now() / 1000) + 1800;
const token = await createSessionToken(
{
Expand All @@ -205,7 +187,6 @@ describe('createSessionToken — Phase 2 fields (accessTokenExpiresAt / refreshT
organizationId: 'org-123',
accessTokenExpiresAt: expiresAt,
refreshToken: 'rt_full',
idToken: 'idt_full',
},
TEST_SECRET,
);
Expand All @@ -217,7 +198,6 @@ describe('createSessionToken — Phase 2 fields (accessTokenExpiresAt / refreshT
expect(payload.organizationId).toBe('org-123');
expect(payload.accessTokenExpiresAt).toBe(expiresAt);
expect(payload.refreshToken).toBe('rt_full');
expect(payload.idToken).toBe('idt_full');
});

it('omits Phase 2 fields when not provided (backward-compat)', async () => {
Expand All @@ -230,6 +210,5 @@ describe('createSessionToken — Phase 2 fields (accessTokenExpiresAt / refreshT
const payload = await verifySessionToken(token, TEST_SECRET);
expect(payload.accessTokenExpiresAt).toBeUndefined();
expect(payload.refreshToken).toBeUndefined();
expect(payload.idToken).toBeUndefined();
});
});
Loading