NuCypher tvl by r-czajkowski · Pull Request #86 · threshold-network/token-dashboard

r-czajkowski · 2022-02-09T15:18:00Z

Depends on: #85

This PR adds support for computing the NU TVL. Implemented based on the nucypher-monitor source code.

Note

This implementation works only on mainnet network. We need to figure out how to get the NuCypherStakingEscrow and NuCypherWorkLock contracts from package for mainnet, ropsten and local network. Would be great if we could have hardhat deployment scripts in https://github.com/nucypher/nucypher-contracts repo to deploy contracts locally and npm packages for mainnet and ropsten contracts. cc @cygnusv @Battenfield.

Run the dapp on mainnet

Set correct packages versions in package.json:

"@keep-network/coverage-pools": "1.0.0",
"@keep-network/keep-core": "1.7.0",
"@keep-network/keep-ecdsa": "1.8.0",
"@keep-network/tbtc": "1.1.0",
"@threshold-network/solidity-contracts": "1.1.0",

Update .env file:

REACT_APP_SUPPORTED_CHAIN_ID=1
REACT_APP_ETH_HOSTNAME_HTTP=https://mainnet.infura.io/v3/<your project ID here>
REACT_APP_ETH_HOSTNAME_WS=wss://mainnet.infura.io/ws/v3/<your project ID here>
REACT_APP_MULTICALL_ADDRESS=$MULTICALL_ADDRESS

Run yarn
Run yarn start

This only work on a mainnet. We need to figure out how to use these contracts on ropsten and local network.

github-actions · 2022-02-09T15:25:35Z

Preview uploaded to https://preview.dashboard.test.threshold.network/nu-tvl/index.html.

cygnusv · 2022-02-09T16:27:11Z

src/hooks/useFetchTvl.ts

+    {
+      contract: nu.contract!,
+      method: "balanceOf",
+      args: [nuStakingEscrow?.address],


Can you clarify why we're tracking here the NU balance of staking escrow?

TBH I implemented based on the https://github.com/nucypher/nucypher-monitor/blob/main/monitor/dashboard.py#L146-L163. Any tips on how to calculate NU TVL correctly would be appreciated 🙂

cygnusv · 2022-02-09T16:31:10Z

src/hooks/useFetchTvl.ts

+    const stakedNU = FixedNumber.fromString(nuInEscrow)
+      .subUnsafe(
+        FixedNumber.fromString(nuTotalSupply).subUnsafe(
+          FixedNumber.fromString(nuCurrenctPeriodSupply)


This equation seems a bit complex and I'm not sure if this yields a correct figure. Depending on what's the goal, i think there are other endpoints that are simpler as input.

Extract some hooks to separate files. Make calculations more readable.

github-actions · 2022-02-15T11:23:00Z

Preview uploaded to https://preview.dashboard.test.threshold.network/nu-tvl/index.html.

georgeweiler · 2022-02-15T18:56:34Z

src/web3/hooks/useNuStakingEscrowContract.ts

+    type: "function",
+  },
+]
+const ESCROW_ADDRESS = "0xbbD3C0C794F40c4f993B03F65343aCC6fcfCb2e2"


What do you think about placing this in our .env? might be better so that we can just add ropsten & local address when they become available? Our env has the supported chainId, so we can be sure to use the correct one based on the env.

I think it's a nice idea 👍 , but hopefully, we can get artifacts for mainnet/ropsten/local network from the package like we do for other contracts. So let's hold for a while and we will see if we can get a separate package for ropsten network.

georgeweiler · 2022-02-15T18:57:14Z

src/web3/hooks/useNuWorkLockContract.ts

+
+// TODO: Get contract abi from the package and figure out how to use these
+// contracts on ropsten and local network. This only works on mainnet.
+const WORK_LOCK_ADDRESS = "0xe9778E69a961e64d3cdBB34CF6778281d34667c2"


same as above

cygnusv · 2022-02-15T19:07:53Z

Would be great if we could have hardhat deployment scripts in https://github.com/nucypher/nucypher-contracts repo to deploy contracts locally and npm packages for mainnet and ropsten contracts.

We recently published an NPM package for this. Check out https://www.npmjs.com/package/@nucypher/nucypher-contracts, the artifacts directory contains the addresses and ABIs of some NU contracts. Let me know if you need something else there (perhaps WorkLock?)

r-czajkowski · 2022-02-16T09:56:38Z

Would be great if we could have hardhat deployment scripts in https://github.com/nucypher/nucypher-contracts repo to deploy contracts locally and npm packages for mainnet and ropsten contracts.

We recently published an NPM package for this. Check out https://www.npmjs.com/package/@nucypher/nucypher-contracts, the artifacts directory contains the addresses and ABIs of some NU contracts. Let me know if you need something else there (perhaps WorkLock?)

Nice thanks! As I can see it only contains the mainnet addresses. Could we have a separate npm package for Ropsten? Something like we have in threshold contracts pacakge? https://www.npmjs.com/package/@threshold-network/solidity-contracts/v/1.1.0-ropsten.0. It will help and simplify the T dapp deployment process on Ropsten network.

Would be great if we could add WorkLock artifact to the package 🙂.

cygnusv · 2022-02-16T10:18:30Z

Would be great if we could have hardhat deployment scripts in https://github.com/nucypher/nucypher-contracts repo to deploy contracts locally and npm packages for mainnet and ropsten contracts.

We recently published an NPM package for this. Check out https://www.npmjs.com/package/@nucypher/nucypher-contracts, the artifacts directory contains the addresses and ABIs of some NU contracts. Let me know if you need something else there (perhaps WorkLock?)

Nice thanks! As I can see it only contains the mainnet addresses. Could we have a separate npm package for Ropsten? Something like we have in threshold contracts pacakge? https://www.npmjs.com/package/@threshold-network/solidity-contracts/v/1.1.0-ropsten.0. It will help and simplify the T dapp deployment process on Ropsten network.

Would be great if we could add WorkLock artifact to the package 🙂.

I'm afraid we don't have a Ropsten deployment of NuCypher contracts. At some point I deployed just the token to facilitate integration of the Vending Machines, but we can't redeploy the whole set of contracts. I think for Ropsten you'd have to mock it somehow.

For mainnet, yes, we can add the WorkLock artifact to the package.

pdyraga · 2022-02-16T12:52:13Z

I'm afraid we don't have a Ropsten deployment of NuCypher contracts. At some point I deployed just the token to facilitate integration of the Vending Machines, but we can't redeploy the whole set of contracts. I think for Ropsten you'd have to mock it somehow.

Why can't we have them redeployed? It's just for Ropsten and they would exist under new -ropsten version, example here: https://www.npmjs.com/package/@threshold-network/solidity-contracts/v/1.1.0-ropsten.0
Alternatively, deploy just WorkLock and whatever is needed and append the new artifacts to the existing package.

r-czajkowski · 2022-02-18T11:55:55Z

^ @cygnusv

Calculate NU tvl based on the on-chain data

a3feefa

This only work on a mainnet. We need to figure out how to use these contracts on ropsten and local network.

r-czajkowski requested review from Battenfield and georgeweiler February 9, 2022 15:18

cygnusv reviewed Feb 9, 2022

View reviewed changes

r-czajkowski requested a review from cygnusv February 10, 2022 07:48

r-czajkowski added 2 commits February 15, 2022 11:43

Clean-up useFetchTvl hook

ae77287

Extract some hooks to separate files. Make calculations more readable.

Update test

5dcd9c5

r-czajkowski marked this pull request as ready for review February 15, 2022 11:17

Base automatically changed from tvl to main February 15, 2022 18:46

georgeweiler reviewed Feb 15, 2022

View reviewed changes

cygnusv mentioned this pull request Feb 16, 2022

Add Worklock artifact (address + ABI) nucypher/nucypher-contracts#14

Closed

Conversation

r-czajkowski commented Feb 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note

Uh oh!

github-actions bot commented Feb 9, 2022

Uh oh!

cygnusv Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

r-czajkowski Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

cygnusv Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 15, 2022

Uh oh!

georgeweiler Feb 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r-czajkowski Feb 16, 2022

Choose a reason for hiding this comment

Uh oh!

georgeweiler Feb 15, 2022

Choose a reason for hiding this comment

Uh oh!

cygnusv commented Feb 15, 2022

Uh oh!

r-czajkowski commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cygnusv commented Feb 16, 2022

Uh oh!

pdyraga commented Feb 16, 2022

Uh oh!

r-czajkowski commented Feb 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

r-czajkowski commented Feb 9, 2022 •

edited

Loading

georgeweiler Feb 15, 2022 •

edited

Loading

r-czajkowski commented Feb 16, 2022 •

edited

Loading