Merged
Conversation
The ConjunctionPolicy requires all the provided policies to pass. It will allow to aggregate pre-params policy with beta operator policy together for tbtc.
All sortition pool policies are now aggregated in a single file.
BetaOperatorPolicy is a JoinPolicy implementation checking chaosnet and beta operator status. If chaosnet has been deactivated, the operator is allowed to join the pool. If chaosnet is active and the operator is beta operator, the operator is allowed to join the pool. If chaosnet is active and the operator is not beta operator, the operator is not allowed to join the pool. The BetaOperatorPolicy is applied both to the random beacon and tbtc.
tomaszslabon
suggested changes
Sep 23, 2022
Just grammar improvements, nothing more.
Contributor
|
It seems to be working as expected. |
tomaszslabon
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3301
See #3302
The code from these two PRs ☝🏻 is needed for testing this code.
See keep-network/sortition-pools#188
After adding chaosnet support to the sortition pool, we need to modify the client to check the chaosnet state before attempting to join the sortition pool.
BetaOperatorPolicyis aJoinPolicyimplementation checking chaosnet and beta operator status. If chaosnet has been deactivated, the operator is allowed to join the pool. If chaosnet is active and the operator is beta operator, the operator is allowed to join the pool. If chaosnet is active and the operator is not beta operator, the operator is not allowed to join the pool.The
BetaOperatorPolicyis applied both to the random beacon and tbtc.