Add Grace Period Contracts check service#1028
Draft
zaelgohary wants to merge 13 commits into
Draft
Conversation
…adlessTask instead of checkNodeStatus, remove finish logic from inside the background service, edit notification service, edit notification dialogue, add more logs
…old_connect into development_grace_period_contracts
Contributor
|
Contributor
|
…old_connect into development_grace_period_contracts
…dle contract alert
AlaaElattar
reviewed
Jun 19, 2025
| logger.i( | ||
| '[ContractsCheck] Contracts in grace period: ${allContractsInGracePeriod.length}. Contract Notifications enabled: $contractNotificationsEnabled'); | ||
|
|
||
| if (contractNotificationsEnabled) { |
Contributor
There was a problem hiding this comment.
- I think we may include more info about contract to be user-friendly, like farm or node. what do u think ?
Contributor
Author
There was a problem hiding this comment.
Surely can be done but there's a contract page where users can check all their contracts details. Maybe we can refer to the contracts page but after its PR is merged? Or redirect to the contract details page on notification click?
Contributor
Author
There was a problem hiding this comment.
I opened the issue below. If all works well, we can approve this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues
Tested Scenarios
A list of scenarios tried to match the deliverables