Conversation
Rifdhan
commented
Oct 1, 2026
- Add new SpotterEmbed config flags
- Add new events
- Add test coverage
- Add new SpotterEmbed config flags - Add new events - Add test coverage
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Spotter usage limits in both SpotterEmbed and AppEmbed. It adds the SpotterUsageLimitConfig interface, SpotterUsageLimitStatus enum, and SpotterRefreshUsageLimitRequest payload, alongside the SpotterUsageLimitUpgrade embed event and SpotterRefreshUsageLimit host event. The initialization logic has been updated to map these configuration flags to embedParams, and comprehensive unit tests have been added to verify their behavior. There are no review comments to evaluate, so I have no further feedback to provide.
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.