Skip to content

[SCAL-338542] Spotter Pricing Package TSE SDK changes - #695

Open
Rifdhan wants to merge 1 commit into
mainfrom
SCAL-338542-spotter-pricing-package
Open

Rifdhan wants to merge 1 commit into
mainfrom
SCAL-338542-spotter-pricing-package

Conversation

@Rifdhan

@Rifdhan Rifdhan commented Oct 1, 2026

Copy link
Copy Markdown
  • Add new SpotterEmbed config flags
  • Add new events
  • Add test coverage

- Add new SpotterEmbed config flags
- Add new events
- Add test coverage
@Rifdhan
Rifdhan requested a review from a team as a code owner October 1, 2026 01:26

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Spotter usage limits in both SpotterEmbed and AppEmbed. It adds the SpotterUsageLimitConfig interface, SpotterUsageLimitStatus enum, and SpotterRefreshUsageLimitRequest payload, alongside the SpotterUsageLimitUpgrade embed event and SpotterRefreshUsageLimit host event. The initialization logic has been updated to map these configuration flags to embedParams, and comprehensive unit tests have been added to verify their behavior. There are no review comments to evaluate, so I have no further feedback to provide.

@pkg-pr-new

pkg-pr-new Bot commented Oct 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@695

commit: 3a01cb4

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant