[SCAL-324479]: Allow up to 2 PRIMARY custom actions per target

[tushardeepakts]

Summary

• Fixed getCustomActions() so the primaryActionsPerTarget map is now enforced, preventing an unlimited number of PRIMARY-position custom actions.
• Added MAX_PRIMARY_ACTIONS_PER_TARGET = 2.
• Updated validateCustomAction to enforce a maximum of 2 valid PRIMARY actions per target:
  • Liveboard
  • Viz
  • Answer
• Additional valid PRIMARY actions are rejected with the new TOO_MANY_PRIMARY_ACTIONS error.
• Only actions that pass all other validation checks consume a primary-action slot.
• Updated the CustomActionsPosition.PRIMARY JSDoc in types.ts to document the 2-action limit.

[gemini-code-assist]

Code Review

This pull request introduces a limit of up to 2 PRIMARY custom actions per target. It updates the validation logic in src/utils/custom-actions.ts to track and enforce this limit, adds a corresponding error message, updates JSDoc documentation, and includes comprehensive unit tests. Feedback on the pull request points out a style guide violation in a JSDoc comment where a complete sentence does not end with a period.

[gemini-code-assist]

According to the repository style guide (Rule 6), every description that forms a complete sentence should end with a period. Please add a period at the end of the description.

Suggested change

	/**
	* Validates a single custom action based on its target type
	* @param action - The custom action to validate
	* @param primaryActionsPerTarget - Map to track primary actions per target
	* @param primaryActionsPerTarget - Map tracking PRIMARY actions accepted so
	* far, keyed by target
	* @returns CustomActionValidation with isValid flag and reason string
	*
	*
	* @hidden
	*/
	/**
	* Validates a single custom action based on its target type.
	* @param action - The custom action to validate
	* @param primaryActionsPerTarget - Map tracking PRIMARY actions accepted so
	* far, keyed by target
	* @returns CustomActionValidation with isValid flag and reason string
	*
	* @hidden
	*/

References

1. Every description that forms a complete sentence should end with a period. ^(link)

[tushardeepakts]

Not needed

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@692

commit: 9ddd9a9