Skip to content

docs(architecture): record ADR-0006 approval - #790

Merged
ja573 merged 2 commits into
developfrom
feature/shared-architecture/adr-0006-approval
Aug 8, 2026
Merged

docs(architecture): record ADR-0006 approval#790
ja573 merged 2 commits into
developfrom
feature/shared-architecture/adr-0006-approval

Conversation

@ja573

@ja573 ja573 commented Aug 8, 2026

Copy link
Copy Markdown
Member

Purpose

Record the CTO's final approval, given on 2026-08-08, of the exact ADR-0006
architecture content previously merged through PR #789
(approved head 8eeb4913034561c3b9387ac6c793927ff2e42fe3,
merge commit 22c7307eb96f05c336b00e80cbf844ec345535a5).

The architecture content itself is already merged and independently reviewed.
This PR exists solely to record the durable approval state required by the
repository's ADR authority rules. It is documentation/control only.

Approval scope

The CTO's approval covers the exact merged ADR-0006 architecture, including:

  • the F2 uniform top-level-response-key scope;
  • the request-scoped batching / set-based loading architecture
    (Option A / A2 look-ahead-driven prefetch, request-scoped state on Context,
    the scoped store identity, NotLoaded/Loaded/LoadFailed, descendant
    prefetch, authorization and key-projector rules);
  • the central mutation duplicate-response-key guard, including its deliberate
    restriction on accepted GraphQL requests;
  • the baseline-validation eligibility gate;
  • the non-mutation fast path;
  • effective-variable handling and the public-callable/doc-hidden Juniper gate
    coupling;
  • the OFF / OBSERVE / ENFORCE production-control lifecycle;
  • the requirement that both production activations carry their own separate
    explicit CTO production activation approval.

The central guard was deliberately escalated for the CTO's own decision. The
approval recorded here resolves that escalation explicitly.

Boundaries

This PR does not:

  • authorize THOTH-GQL-BATCH-01 implementation (it remains DRAFT,
    implementation NOT AUTHORIZED);
  • create the THOTH-GQL-BATCH-01 runtime implementation branch;
  • authorize the OFF -> OBSERVE production activation;
  • authorize the OBSERVE -> ENFORCE production activation;
  • resolve control gap CG-13;
  • resolve the outstanding monitoring / activation-threshold evidence;
  • authorize BE-02 implementation;
  • change production behaviour.

No architecture is changed. Store identity, scope semantics, F2, the fast path,
eligibility validation, effective variables, directive behaviour, error
semantics, descendant traversal, key projection, failure states, N+1 evidence,
set-based SQL requirements, Juniper API conclusions, production mode semantics,
activation gates, CG-13 requirements, monitoring requirements and BE-02
ordering are all unchanged. The ADR diff is confined to the header block and
section 14.

Production activation readiness remains BLOCKED: CG-13 runtime operations
unresolved, monitoring/thresholds unverified.

Authority

ADR-0006 becomes repository-authoritative only when this exact approved-state
content is independently reviewed and merged into develop.

Status: APPROVED on this branch is not authoritative before it merges.

Review requirement

The exact head of this PR requires fresh independent exact-head review. This
approval-recording PR is not approved for merge, and nothing here should be
read as self-approval. Merge requires independent exact-head review, explicit
CTO merge authorization, and an expected-head guarded merge.

Files changed

  • docs/engineering/decisions/ADR-0006-request-scoped-graphql-batching.md
  • docs/engineering/decisions/decision-register.md
  • CHANGELOG.md

@ja573
ja573 marked this pull request as ready for review August 8, 2026 11:38
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@ja573
ja573 merged commit df2e2ef into develop Aug 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant