[Automated] Update az CLI Options - #4955
Conversation
thomhurst
added
automated
dependencies
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Greptile SummaryThis automated regeneration updates Azure CLI option models to represent value-taking arguments as strings or collections instead of Boolean flags, refreshes public API declarations and generated metadata, and documents the current global-option ordering.
Confidence Score: 3/5The PR is not safe to merge until the newly exposed SQL VM password properties participate in command secret redaction. Five password-bearing SQL VM properties now carry caller-supplied strings but are omitted from the metadata used to register and obfuscate secrets, allowing credentials to appear in observable command output. Files Needing Attention: src/ModularPipelines.Azure/Options/AzSqlVmAddToGroupOptions.Generated.cs, src/ModularPipelines.Azure/Options/AzSqlVmCreateOptions.Generated.cs, src/ModularPipelines.Azure/Options/AzSqlVmUpdateOptions.Generated.cs
|
| Filename | Overview |
|---|---|
| src/ModularPipelines.Azure/Options/AzSqlVmAddToGroupOptions.Generated.cs | Converts three SQL VM group account passwords to string options but omits the secret metadata required for redaction. |
| src/ModularPipelines.Azure/Options/AzSqlVmCreateOptions.Generated.cs | Converts the backup-encryption password to a value-taking option without marking it as sensitive. |
| src/ModularPipelines.Azure/Options/AzSqlVmUpdateOptions.Generated.cs | Introduces the same missing secret classification for backup-encryption password updates. |
| src/ModularPipelines.Azure/PublicAPI.Unshipped.txt | Records the generated assembly-wide API signature changes resulting from corrected CLI option types. |
| src/ModularPipelines.Azure/Generated/Az.Generation.json | Refreshes the generator-source fingerprint while retaining the same Azure CLI version and command-tree fingerprint. |
Reviews (1): Last reviewed commit: "chore: Update az CLI options" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ea3b2d84e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Review: [Automated] Update az CLI Options (#4955) This is a fully generated regeneration of Two things worth fixing before/around merging this, both in the generator rather than this PR's generated files: 1. Base branch is stale relative to This PR targets Concretely: this PR's regenerated Suggested fix: retarget this PR at 2. Secret-detection misses the common
Each is documented as "Password for ..." — these are genuine secrets that will now be rendered in plaintext in pipeline logs instead of being obfuscated. Suggested fix: extend Neither issue is something to hand-fix in this PR's generated files — both need the generator/scraper fixed and a regeneration, per the repo's stated workflow. |
|
Holding this generated head for the source fixes identified in review: SQL VM *AccPwd/BackupPwd values need SecretValue classification, and VM/VMSS AdminUsername must stay scalar despite help mentioning reserved-value lists. Both changes belong in the generator on #4546 followed by full Azure regeneration; generated options will not be hand-edited. Existing source provenance and 5,131-command coverage match, but passing checks do not resolve these contract defects. |
1ea3b2d to
9168b8b
Compare
|
Too many files changed for review (116 files, 100 file limit). Bypass the limit by tagging |
|
Review This is an automated Blocking:
Per this repo's rule that generated content should only ever come from the generator (never hand-edited, including during review), please regenerate |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9168b8b078
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Comment 5661706471's documentation finding does not match the reviewed head. I read these files directly through GitHub's contents API at 9168b8b:
There is still a separate, genuine freshness blocker. This output's manifest fingerprint is 44ca29f5f7a70bca3524d42172fd82be9545fbcf615b95d441cd8609a513bad8, from the preceding source. Parent #4546 now includes the NetApp list-definition fix at 9eaa3b9, fingerprint a6c1ce44cc70d83e8347ded58b42d94a37c0ba27ca672676467daf26a2fc6bb6. The failed Fast fail check correctly rejects that mismatch. Replacement generation is running at https://github.com/thomhurst/ModularPipelines/actions/runs/34826041981. This PR stays unmerged until final-source output, integration validation, and review pass. No generated files were manually edited or failing checks rerun. |
9168b8b to
7450023
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7450023994
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7450023 to
ed8351d
Compare
ReviewThis is a follow-up regeneration of the
The rest of the diff is the same systematic, mechanical pattern applied consistently across all 110 changed option files: previously-mistyped No new issues found. This looks ready to merge pending normal CI/integration validation. |
* chore(azure): refresh generated options * fix(azure): detect description-only values * ci(options): retain Azure generation patch * ci(options): remove temporary Azure recovery workflow changes (#4331) * fix(options): recognize Azure named values and repeated image tags (#4331) * fix(generator): preserve required parameter documentation (#4739) (cherry picked from commit f16a6e7) * fix(ci): isolate feature-branch generation output (#4797) (cherry picked from commit 9531494) * fix(ci): bound Azure API build concurrency (#4331) * ci(generator): preserve API build diagnostics (#4331) * ci: sample stalled Azure API compiler (#4331) * perf(generator): snapshot additions before API removal analysis (#4331) * fix(generator): report case-only renames in change manifests (#4331) * refactor(generator): separate coverage failure and file writes (#4331) * fix(azure): recover current output and quoted repeat examples (#4331) * chore: Update az CLI options (#4951) Co-authored-by: thomhurst <9139608+thomhurst@users.noreply.github.com> * fix(generator): preserve Azure credentials and datetime values (#4331) * fix(generator): classify Azure passwords and scalar usernames (#4331) * fix(generator): preserve Azure list definitions after introductory prose (#4331) * fix(generator): preserve qualified Azure list definitions (#4331) * chore: Update az CLI options (#4955) Co-authored-by: thomhurst <9139608+thomhurst@users.noreply.github.com> --------- Co-authored-by: thomhurst <9139608+thomhurst@users.noreply.github.com>
1 participant
Summary
This PR contains automatically generated updates to az CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Assembly-wide public API impact
Affected API families:
Az.Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.
Representative removed or changed members:
ModularPipelines.Azure.Options.AzAcrImportOptions.Password.get -> bool?ModularPipelines.Azure.Options.AzAcrImportOptions.Username.get -> bool?ModularPipelines.Azure.Options.AzAcrLoginOptions.Password.get -> bool?ModularPipelines.Azure.Options.AzAcrLoginOptions.Username.get -> bool?ModularPipelines.Azure.Options.AzAcrRepositoryDeleteOptions.Password.get -> bool?Representative added members:
ModularPipelines.Azure.Options.AzAcrImportOptions.Password.get -> string?ModularPipelines.Azure.Options.AzAcrImportOptions.Username.get -> string?ModularPipelines.Azure.Options.AzAcrLoginOptions.Password.get -> string?ModularPipelines.Azure.Options.AzAcrLoginOptions.Username.get -> string?ModularPipelines.Azure.Options.AzAcrRepositoryDeleteOptions.Password.get -> string?Command coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator