Skip to content

[Automated] Update pnpm CLI Options - #4861

Closed
thomhurst wants to merge 1 commit into
issue-4691-pnpm-clap-helpfrom
automated/update-cli-options-pnpm
Closed

thomhurst wants to merge 1 commit into
issue-4691-pnpm-clap-helpfrom
automated/update-cli-options-pnpm

Conversation

@thomhurst

@thomhurst thomhurst commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Summary

This PR contains automatically generated updates to pnpm CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Assembly-wide public API impact

No active public API changes were detected in this assembly.

Command coverage

Command coverage report:

  • pnpm (12.4.1): 103 commands, tree ed0aa4ad19ed65abb387f2af96478f8f91f9e15f197104835663fac5ba17c2d1
    • Baseline comparison: 103 commands at 12.4.1 -> 103 commands at 12.4.1
    • Excluded: pnpm audit signatures (pnpm 12.4.1 no longer lists this path in a Commands section or exposes a distinct child synopsis. The parent command documents [PARAMS]... instead; use its generated Params operand.), pnpm stage approve (pnpm 12.4.1 no longer lists this path in a Commands section or exposes a distinct child synopsis. The parent command documents [PARAMS]... instead; use its generated Params operand.), pnpm stage download (pnpm 12.4.1 no longer lists this path in a Commands section or exposes a distinct child synopsis. The parent command documents [PARAMS]... instead; use its generated Params operand.), pnpm stage list (pnpm 12.4.1 no longer lists this path in a Commands section or exposes a distinct child synopsis. The parent command documents [PARAMS]... instead; use its generated Params operand.), pnpm stage publish (pnpm 12.4.1 no longer lists this path in a Commands section or exposes a distinct child synopsis. The parent command documents [PARAMS]... instead; use its generated Params operand.), pnpm stage reject (pnpm 12.4.1 no longer lists this path in a Commands section or exposes a distinct child synopsis. The parent command documents [PARAMS]... instead; use its generated Params operand.), pnpm stage view (pnpm 12.4.1 no longer lists this path in a Commands section or exposes a distinct child synopsis. The parent command documents [PARAMS]... instead; use its generated Params operand.)

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels Sep 13, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T16:30:27.782525Z 79b3fbb New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4309c7b3-2859-4cb2-a0a7-5c79e7fdf761

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b97a02fd8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ModularPipelines.Node/Services/Pnpm.Generated.cs Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Code Review

This is an automated, single-commit PR generated by ModularPipelines.OptionsGenerator that refreshes the pnpm CLI option classes against pnpm 12.4.1 (previously 11.25.0). I reviewed it against CLAUDE.md's generated-code rules rather than as hand-written code.

Findings: none actionable.

  • All inspectable changed files are confined to the expected generated surface: src/ModularPipelines.Node/{Enums,Options,Services,Generated}/* (enum classes, *.Generated.cs options/service files, Pnpm.Generation.json, Pnpm.CommandCoverage.json) plus PublicAPI.Shipped/Unshipped.txt and the generated doc page docs/docs/mp-packages/cli/pnpm.md (which carries the <!-- This file is generated by ModularPipelines.OptionsGenerator. --> marker). No hand-written source, generator/scraper code under tools/ModularPipelines.OptionsGenerator/, or test files are touched.
  • IPnpm/Pnpm remain fully generated (Services/IPnpm.Generated.cs, Services/Pnpm.Generated.cs) with no manual partial/extension file, so there's nothing to hand-sync for the new/removed commands.
  • Per CLAUDE.md, current generator output is authoritative even where it breaks prior API shape, and the diff should not be hand-edited to preserve removed members — the PR correctly does not add any shims/aliases for the removed pnpm APIs (e.g. PnpmAddOptions.AllowBuild, .GlobalDir).
  • Single commit, matches the pattern of the prior accepted automated tool-options PR ([Automated] Update jq CLI Options #4851 for jq).

Note: the PR's diff exceeds GitHub's 300-file API diff limit, so I wasn't able to enumerate all ~342 changed files directly; I sampled the file list (first 100, all under the expected src/ModularPipelines.Node scope) and spot-checked representative files rather than reading every generated file byte-for-byte. Given the mechanical, single-purpose nature of this generator run, that sampling is sufficient to conclude there's nothing outside the expected generated scope.

No prior review comments from Claude exist on this PR to reconcile.

@thomhurst
thomhurst force-pushed the automated/update-cli-options-pnpm branch from 5b97a02 to 79b3fbb Compare September 13, 2026 16:28
@greptile-apps

greptile-apps Bot commented Sep 13, 2026

Copy link
Copy Markdown

Greptile Summary

This PR refreshes the generated pnpm service after the generator began emitting context-independent awaits.

  • Adds ConfigureAwait(false) to every generated pnpm command facade, aligning the output with the repository’s asynchronous library-code convention.
  • Updates the generator-source provenance hash while retaining pnpm 12.4.1 and the existing command-tree fingerprint.
  • Does not change the generated command surface or public API.

Confidence Score: 5/5

The PR appears safe to merge because it changes only continuation handling within generated facade methods and keeps the pnpm command surface unchanged.

Every changed method immediately returns the same command result after an await, so suppressing context capture introduces no context-dependent work inside the facade; the metadata update is consistent with a generator-only output change.

Important Files Changed

Filename Overview
src/ModularPipelines.Node/Services/Pnpm.Generated.cs Adds ConfigureAwait(false) consistently to generated command-execution awaits without changing command arguments, return values, or API signatures.
src/ModularPipelines.Node/Generated/Pnpm.Generation.json Updates generator provenance while preserving the tool version and command-tree fingerprint.

Reviews (1): Last reviewed commit: "chore: Update pnpm CLI options" | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Code Review

This PR is a single-purpose, automated regeneration of the pnpm CLI options (ModularPipelines.OptionsGenerator). The diff is confined to src/ModularPipelines.Node/Generated/Pnpm.Generation.json (hash bump) and src/ModularPipelines.Node/Services/Pnpm.Generated.cs, where all 103 return await _command.ExecuteCommandLineToolAsync(...) calls gain .ConfigureAwait(false).

Findings: none actionable.

  • Verified 103 removed/added lines match 1:1, and every method's default-options argument still corresponds to its own method (no cross-method copy/paste error), consistent with the prior review's sampling.
  • ConfigureAwait(false) on the final await of an async method only affects continuation-context capture — no change to control flow, return value, or exception behavior, and the public IPnpm surface is untouched.
  • This is exactly the convention CLAUDE.md mandates for library code under src/ ("Library code under src/ uses ConfigureAwait(false)"), and the fix lives in generator output (evidenced by the generatorSourceSha256 bump) rather than a hand-edited shim, matching the "never hand-edit generated options" and "fix the generator, not the output" constraints.
  • No test or generator/scraper source is touched, so nothing needs to sync elsewhere.

Compared against the prior review on this PR (verdict CLEAR at commit 5b97a02): that review covered the same class of change (ConfigureAwait additions to generated pnpm code) and found no issues; this update is consistent with it and introduces no new concerns.

@thomhurst

Copy link
Copy Markdown
Owner Author

Both generated outputs are incorporated into #4713: the full pnpm 12.4.1 API refresh and final ConfigureAwait(false) regeneration (13dbeb1). The Node/docs trees match this generated head, current-head Claude review is CLEAR, and Greptile rates it 5/5. Closing this child as incorporated; the parent remains open for Node test execution and its full CI/review gates.

@thomhurst thomhurst closed this Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant