[Automated] Update yarn CLI Options - #4563
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Yarn public API listings update option constructors, properties, record types, generated members, and ChangesYarn public API
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This updates Yarn public API tracking for current CLI option contracts and command signatures. No concrete current-head issue remains that blocks merge. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This PR only touches tracking/metadata files for the Yarn tool integration: a new src/ModularPipelines.Yarn/Generated/Yarn.Generation.json provenance manifest, plus updates to PublicAPI.Shipped.txt / PublicAPI.Unshipped.txt. No .cs source is changed here — the generated Options/*.Generated.cs and Services/IYarn.Generated.cs files were already updated in an earlier commit (dfb29c9012, "Refresh stale generated integration pull requests (#4445)"); this PR simply catches the public-API-tracking files up to match that already-committed code.
Verified:
- Every
*REMOVED*/added entry inPublicAPI.Unshipped.txtcorresponds exactly to what's declared in the current.csfiles (checkedYarnExecOptions,YarnPatchCommitOptions,YarnPatchOptions,YarnWhyOptions,YarnDlxOptions,YarnWorkspaceOptions.Generated.cs). - No duplicate lines, no symbol present in both Shipped and Unshipped simultaneously.
- Both
PublicAPI.Shipped.txtandPublicAPI.Unshipped.txtremain fully alphabetically sorted after the edit. Yarn.Generation.json'scommandTreeSha256/toolVersionmatchYarn.CommandCoverage.jsonexactly.- No in-repo call sites invoke the now-required-parameter methods (
ExecAsync,PatchAsync,PatchCommitAsync,WhyAsync) withnull/omitted options, so tightening optional→required options parameters breaks nothing internally, and this kind of breaking change from regenerated tool output is explicitly sanctioned by this repo's CLAUDE.md guidance ("Current tool output is the sole source of truth for generated options, even when regeneration causes breaking API changes").
No correctness, design, or convention issues found. Nothing actionable to flag.
|
Ubuntu failure is unrelated to this Yarn metadata-only diff: |
3927b3a to
fc7de01
Compare
There was a problem hiding this comment.
Code Review
Same scope as the previous review of this PR: only tracking/metadata files for the Yarn tool integration change — src/ModularPipelines.Yarn/Generated/Yarn.Generation.json (new provenance manifest) plus PublicAPI.Shipped.txt / PublicAPI.Unshipped.txt updates. No .cs source is touched in this diff; it just catches the public-API-tracking files up to the already-generated code.
Re-verified against current main + this branch's head:
PublicAPI.Shipped.txtandPublicAPI.Unshipped.txtare both fully alphabetically sorted, and no symbol appears in both files simultaneously.- Every
*REMOVED*/added entry (e.g.YarnExecOptions,YarnPatchOptions,YarnPatchCommitOptions,YarnWhyOptionslosing their parameterless constructors; newYarnDlxOptions/YarnWorkspaceOptions) matches exactly what's declared in the currentOptions/*.Generated.csandServices/IYarn.Generated.csfiles (ExecAsync,PatchAsync,PatchCommitAsync,WhyAsync,DlxAsync,WorkspaceAsyncall take required, non-nullable options parameters in the generated interface, matching the tracking file). Yarn.Generation.json'stoolVersion/commandTreeSha256matchYarn.CommandCoverage.jsonexactly.- Tightening these options parameters from optional→required is a breaking change from regenerated tool output, which is explicitly sanctioned by this repo's CLAUDE.md ("Current tool output is the sole source of truth for generated options, even when regeneration causes breaking API changes").
No correctness, design, or convention issues found. Nothing actionable to flag.
There was a problem hiding this comment.
Code Review
Re-reviewed at the current head as requested. This PR's diff against main is unchanged in substance from the two prior reviews of this PR — it still only touches Yarn tracking/metadata files:
src/ModularPipelines.Yarn/Generated/Yarn.Generation.json(new provenance manifest)src/ModularPipelines.Yarn/PublicAPI.Shipped.txtsrc/ModularPipelines.Yarn/PublicAPI.Unshipped.txt
The 14 commits added since the last review (fc7de01 → 0c2b132) are unrelated automated tool updates (flux, shellcheck, trivy, nbgv, winget, pnpm, minikube, grype, ansible, terraform, flyway) plus a docs: tweak and a chore(terraform) cleanup, merged in from main — none of them touch anything under src/ModularPipelines.Yarn/. gh pr diff confirms the file set is still exactly the three files above.
Re-verified:
PublicAPI.Shipped.txtandPublicAPI.Unshipped.txtremain fully alphabetically sorted, and no symbol appears in both files simultaneously.- Every
*REMOVED*/added entry (parameterless constructors dropped forYarnExecOptions,YarnPatchCommitOptions,YarnPatchOptions,YarnWhyOptions; newYarnDlxOptions/YarnWorkspaceOptions;ExecAsync/PatchAsync/PatchCommitAsync/WhyAsync/DlxAsync/WorkspaceAsyncgaining required, non-nullable options parameters) matches the already-committed generated.cssource from the earlier "Refresh stale generated integration pull requests" commit — this PR is solely catching the tracking files up to code that already exists onmain. Yarn.Generation.json'scommandTreeSha256/toolVersionmatch the PR description's command-coverage report (e257eecd9..., yarn 4.18.0).- The optional→required parameter tightening is a breaking change from regenerated tool output, which is explicitly sanctioned by this repo's CLAUDE.md ("Current tool output is the sole source of truth for generated options, even when regeneration causes breaking API changes").
No correctness, design, or convention issues found. Nothing actionable to flag.
Summary
This PR contains automatically generated updates to yarn CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Command coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator
Summary by CodeRabbit
New Features
dlx.Breaking Changes