Composer integration, PSR coding standards#6
Open
a-vasyliev wants to merge 8 commits intothomasbachem:masterfrom
a-vasyliev:master
Open
Composer integration, PSR coding standards#6a-vasyliev wants to merge 8 commits intothomasbachem:masterfrom a-vasyliev:master
a-vasyliev wants to merge 8 commits intothomasbachem:masterfrom
a-vasyliev:master
Conversation
There was a problem hiding this comment.
git mv might not do what you think it does. He likely made enough changes to the file that it's no longer recognized as a rename.
|
👍 |
|
Please merge this! |
| #!/usr/bin/env php | ||
| <?php | ||
|
|
||
| include(__DIR__ . '/../array-converter.php'); |
There was a problem hiding this comment.
include is a special language construct
include __DIR__ . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'array-converter.php';
|
can we have these PR pull from master to be updated? |
vincentchalamon
suggested changes
Feb 17, 2017
There was a problem hiding this comment.
Thanks @a-vasyliev for your contribution :-)
Please rebase from master.
@thomasbachem Is this project still maintained?
| $saveFile = false; | ||
|
|
||
| if ($argc > 3) { | ||
| file_put_contents('php://stderr', 'Usage: php convert.php [-w] <file>' . "\n"); |
There was a problem hiding this comment.
'Usage: php array-converter.php…'
|
|
||
| if ($isArraySyntax) { | ||
| // Replace "array" and the opening bracket (including preceeding whitespace) with "[" | ||
| $replacements[] = array( |
There was a problem hiding this comment.
Maybe you could use short syntax array in this short syntax array converter? 😉
| file_put_contents($filePath, $code); | ||
| } else { | ||
| print $code; | ||
| } No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, here is my proposal of improvement of your great work. Thank you for nice script. I've only added possibility to integrate your work into Composer to be able easily use it inside Composer-based projects. Also, I've found useful to migrate to PSR coding standards (it is used by most modern big PHP projects)