Skip to content

Add base account sdk #8634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquim-verges merged 2 commits into from
Jan 21, 2026
+6,011 −3,094
Merged

Add base account sdk #8634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28b8171
[SDK] Add support for base-org/account SDK
montycheese Jan 16, 2026
899db02
generate wallet ids, add base logo
joaquim-verges Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/add-base-account-sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"thirdweb": minor
---

Add Base Account SDK integration with `@base-org/account`

- Add @base-org/account 2.5.0 dependency
- Introduce Base Account SDK wallet connector
- Add base-account-web.ts with EIP-1193 provider implementation
- Add base-account-wallet.ts with core wallet logic
- Add types and helper function exports
1 change: 1 addition & 0 deletions packages/thirdweb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"url": "https://github.com/thirdweb-dev/js/issues"
},
"dependencies": {
"@base-org/account": "2.5.0",
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# Query npm registry for `@base-org/account` version 2.5.0
curl -s https://registry.npmjs.org/@base-org/account | jq '.versions["2.5.0"] | {version, dist: .dist | {tarball, shasum}}'

Repository: thirdweb-dev/js

Length of output: 240

🏁 Script executed:

# Also check the latest version available
curl -s https://registry.npmjs.org/@base-org/account | jq '.["dist-tags"]'

Repository: thirdweb-dev/js

Length of output: 204

🏁 Script executed:

# Check the current package.json to understand size-limit configuration
head -50 packages/thirdweb/package.json

Repository: thirdweb-dev/js

Length of output: 1487

🏁 Script executed:

# Search for size-limit configuration in package.json
grep -A 20 "size-limit" packages/thirdweb/package.json

Repository: thirdweb-dev/js

Length of output: 2457

🏁 Script executed:

# Also check if the change included updates to size-limit
git diff HEAD -- packages/thirdweb/package.json | head -100

Repository: thirdweb-dev/js

Length of output: 41

🏁 Script executed:

# Search for size-limit configuration array in the entire package.json
cat packages/thirdweb/package.json | jq '.["size-limit"]' 2>/dev/null || echo "No size-limit array found in package.json"

Repository: thirdweb-dev/js

Length of output: 63

🏁 Script executed:

# Also check the end of the file to see if size-limit config is there
tail -100 packages/thirdweb/package.json

Repository: thirdweb-dev/js

Length of output: 3731

Add size-limit configuration for the new @base-org/account dependency.

The @base-org/account package at version 2.5.0 is valid and follows the existing exact-version pinning pattern. However, per the coding guidelines, bundle budgets must be tracked via package.json#size-limit. The current package.json lacks a size-limit configuration array—add an entry for this dependency to track its bundle size impact. Additionally, consider updating to version 2.5.1 (the latest patch), as it's more recent than 2.5.0.

🤖 Prompt for AI Agents 
In `@packages/thirdweb/package.json` at line 14, Update package.json to include a
size-limit configuration array and add an entry tracking the new
`@base-org/account` dependency (identify the package by its name
"@base-org/account" and include a descriptive label in the size-limit entry),
and change the dependency version to the latest patch (2.5.1) instead of 2.5.0;
ensure the size-limit array follows the existing project format and includes the
package path or import target used by the build so bundle budgets are enforced
for `@base-org/account`.

"@coinbase/wallet-sdk": "4.3.0",
"@emotion/react": "11.14.0",
"@emotion/styled": "11.14.1",
Expand Down
11 changes: 11 additions & 0 deletions packages/thirdweb/scripts/wallets/extra-wallet-icons/base.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
28 changes: 28 additions & 0 deletions packages/thirdweb/scripts/wallets/extra-wallets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,5 +175,33 @@
"native": null,
"universal": null
}
},
{
"id": "org.base.account",
"name": "Base Account",
"homepage": "https://base.org/",
"image_id": "base.svg",
"app": {
"browser": null,
"ios": null,
"android": null,
"mac": null,
"windows": null,
"linux": null,
"chrome": null,
"firefox": null,
"safari": null,
"edge": null,
"opera": null
},
"rdns": "org.base.account",
"mobile": {
"native": null,
"universal": null
},
"desktop": {
"native": null,
"universal": null
}
}
]
5 changes: 5 additions & 0 deletions packages/thirdweb/src/exports/wallets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ export type {
InjectedSupportedWalletIds,
WCSupportedWalletIds,
} from "../wallets/__generated__/wallet-ids.js";
export type {
BaseAccountSDKWalletConnectionOptions,
BaseAccountWalletCreationOptions,
} from "../wallets/base-account/base-account-web.js";
export { isBaseAccountSDKWallet } from "../wallets/base-account/base-account-web.js";
export type {
CoinbaseSDKWalletConnectionOptions,
CoinbaseWalletCreationOptions,
Expand Down
Loading